use authname instead of displayname for vcard filename (#4233)

* use authname instead of displayname for vcard filename closes #4230 * use address if authname is empty * Add pr number to changelog
deltachat · Oct 21, 2024 · 1ebcc5a · 1ebcc5a
1 parent 9bcca06
commit 1ebcc5a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -57,6 +57,7 @@
 - some reactions dialog items not being clickable on secondary accounts (profiles) #4228
 - target-electron: make sure log of stdio server is also logged to file
 - improve accessibility a little #4133
+- use authname instead of displayname for vcard filename #4233
 
 
 <a id="1_46_8"></a>

diff --git a/packages/frontend/src/components/composer/menuAttachment.tsx b/packages/frontend/src/components/composer/menuAttachment.tsx
@@ -119,12 +119,12 @@ export default function MenuAttachment({
           selectedAccountId(),
           [selectedContact.id]
         )
-        const cleanDisplayname = selectedContact.displayName.replace(
-          /[^a-z_A-Z0-9]/gi,
-          ''
-        )
+        // Use original name set by contact instead of nickname chosen by user
+        const cleanAuthname = (
+          selectedContact.authName || selectedContact.address
+        ).replace(/[^a-z_A-Z0-9]/gi, '')
         const tmp_file = await runtime.writeTempFile(
-          `VCard-${cleanDisplayname}.vcf`,
+          `VCard-${cleanAuthname}.vcf`,
           vCardContact
         )
         addFileToDraft(tmp_file, 'Vcard')