Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buttons accept HTMLButton props #4221

Merged
merged 2 commits into from
Oct 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/frontend/src/components/Avatar/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import useDialog from '../../hooks/dialog/useDialog'
import FullscreenAvatar from '../dialogs/FullscreenAvatar'

import type { Type } from '../../backend-com'
import type { PropsWithChildren } from 'react'
import { get_first_emoji } from '@deltachat/message_parser_wasm'

import styles from './styles.module.scss'
Expand Down Expand Up @@ -99,9 +98,9 @@ export function AvatarFromContact(
}

export function ClickForFullscreenAvatarWrapper(
props: PropsWithChildren<{
props: React.ButtonHTMLAttributes<HTMLButtonElement> & {
filename?: string
}>
}
) {
const { openDialog } = useDialog()

Expand All @@ -115,6 +114,7 @@ export function ClickForFullscreenAvatarWrapper(
imagePath: filename!,
})
}}
{...props}
>
{children}
</button>
Expand Down
29 changes: 9 additions & 20 deletions packages/frontend/src/components/Button/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,38 +3,27 @@ import classNames from 'classnames'

import styles from './style.module.scss'

type Props = React.PropsWithChildren<{
'aria-label'?: string
className?: string
disabled?: boolean
export type ButtonProps = React.ButtonHTMLAttributes<HTMLButtonElement> & {
active?: boolean
id?: string
onClick: any
type?: 'primary' | 'secondary' | 'danger'
}>
styling?: 'primary' | 'secondary' | 'danger'
}

export default function Button({
children,
disabled = false,
active = false,
id,
onClick,
type,
styling,
className,
...props
}: Props) {
}: ButtonProps) {
return (
<button
id={id}
disabled={disabled}
role='button'
className={classNames(
styles.button,
active && styles.active,
type && styles[type],
props.className
styling && styles[styling],
className
)}
onClick={onClick}
aria-label={props['aria-label']}
{...props}
>
{children}
</button>
Expand Down
21 changes: 4 additions & 17 deletions packages/frontend/src/components/Dialog/FooterActionButton.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,29 +2,16 @@ import React from 'react'

import Button from '../Button'

import type { MouseEventHandler, PropsWithChildren } from 'react'
import type { ButtonProps } from '../Button'

import styles from './styles.module.scss'

type Props = PropsWithChildren<{
onClick: MouseEventHandler<HTMLButtonElement>
disabled?: boolean
danger?: boolean
}>

export default function FooterActionButton({
children,
onClick,
disabled = false,
danger = false,
}: Props) {
...props
}: ButtonProps) {
return (
<Button
className={styles.footerActionButton}
onClick={onClick}
type={danger ? 'danger' : undefined}
disabled={disabled}
>
<Button className={styles.footerActionButton} {...props}>
{children}
</Button>
)
Expand Down
2 changes: 1 addition & 1 deletion packages/frontend/src/components/LoginForm.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -443,7 +443,7 @@ export function ConfigureProgressDialog({
</DialogBody>
<DialogFooter>
<FooterActions>
<FooterActionButton danger onClick={onCancel}>
<FooterActionButton styling='danger' onClick={onCancel}>
{tx('cancel')}
</FooterActionButton>
</FooterActions>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ export const StickerPicker = ({
))}
</div>
<div className='sticker-actions-container'>
<Button type='secondary' onClick={onOpenStickerFolder}>
<Button styling='secondary' onClick={onOpenStickerFolder}>
{tx('open_sticker_folder')}
</Button>
</div>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ export default function ConfirmationDialog({
{cancelLabel || tx('cancel')}
</FooterActionButton>
<FooterActionButton
danger={isConfirmDanger}
styling={isConfirmDanger ? 'danger' : undefined}
onClick={() => handleClick(true)}
>
{confirmLabel || tx('yes')}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ export function ViewProfileInner({
>
{!isDeviceChat && (
<Button
type='primary'
styling='primary'
aria-label={tx('send_message')}
onClick={onSendMessage}
>
Expand Down
2 changes: 1 addition & 1 deletion packages/frontend/src/components/message/Message.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -850,7 +850,7 @@ function WebxdcMessageContent({ message }: { message: T.Message }) {
)}
<Button
className={styles.startWebxdcButton}
type='primary'
styling='primary'
onClick={() => openWebxdc(message.id)}
>
{tx('start_app')}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ export default function AccountDeletionScreen({
{tx('cancel')}
</FooterActionButton>
<FooterActionButton
danger={true}
styling='danger'
onClick={async () => onDeleteAccount(selectedAccountId)}
>
{tx('delete')}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -75,14 +75,14 @@ export default function AlternativeSetupsDialog({
<DialogBody>
<DialogContent>
<Button
type='secondary'
styling='secondary'
className={styles.welcomeScreenButton}
onClick={onClickSecondDevice}
>
{tx('multidevice_receiver_title')}
</Button>
<Button
type='secondary'
styling='secondary'
className={styles.welcomeScreenButton}
onClick={onClickImportBackup}
>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ export default function InstantOnboardingScreen({
</div>
<Button
className={styles.welcomeScreenButton}
type='primary'
styling='primary'
onClick={onConfirm}
>
{welcomeQr?.qr.kind === 'login'
Expand All @@ -171,7 +171,7 @@ export default function InstantOnboardingScreen({
</Button>
<Button
className={styles.welcomeScreenButton}
type='secondary'
styling='secondary'
onClick={showOtherOptions}
>
{tx('instant_onboarding_show_more_instances')}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -80,14 +80,14 @@ export default function OnboardingScreen(props: Props) {
<div className={styles.welcomeScreenButtonGroup}>
<Button
className={styles.welcomeScreenButton}
type='primary'
styling='primary'
onClick={props.onNextStep}
>
{tx('onboarding_create_instant_account')}
</Button>
<Button
className={styles.welcomeScreenButton}
type='secondary'
styling='secondary'
onClick={onAlreadyHaveAccount}
>
{tx('onboarding_alternative_logins')}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ export default function UseOtherServerDialog({ onClose }: DialogProps) {
<DialogBody>
<DialogContent>
<Button
type='secondary'
styling='secondary'
className={styles.welcomeScreenButton}
onClick={onShowMoreInstances}
>
Expand All @@ -54,14 +54,14 @@ export default function UseOtherServerDialog({ onClose }: DialogProps) {
</Button>

<Button
type='secondary'
styling='secondary'
className={styles.welcomeScreenButton}
onClick={onClickLogin}
>
{tx('manual_account_setup_option')}
</Button>
<Button
type='secondary'
styling='secondary'
className={styles.welcomeScreenButton}
onClick={onScanQRCode}
>
Expand Down
Loading