show "Mark All As Read" in account menu unconditionally and move it down, right over settings menu item #4234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…own, right over settings menu item closes #3979
Simon-Laux
force-pushed
the
simon/i3979-show-Mark-All-As-Read-unconditionally
branch
from
1d505ad
to
19e70f2
Compare
WofWca
approved these changes
Oct 21, 2024
r10s
approved these changes
Oct 21, 2024
There was a problem hiding this comment.
very nice, this is much better than before!
"Archive Messages" needs to be marked as read as well, however: "all" on account level includes "Archive Messages" already visually. just all "blue badges" for and "grey badges" for that account should disappear when tapping "Mark All As Read":)
but that can also go to another PR/issue if showhow complicated
really confusing sentence, I don't get that. I assume marking archived chats as read will address that, but please say if you meant something else. |
|
there were wrong words in that sentence, i fixed that above. but yes, "marking archived chats as read" was what i meant. thanks a lot! |
r10s
approved these changes
Oct 21, 2024
Simon-Laux
deleted the
simon/i3979-show-Mark-All-As-Read-unconditionally
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3979