Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
iirc, the idea of
releases.md
is to see at one glance the status of releases for all distribution channels. so, what is really out there :)to achieve that, it may be needed to update
releases.md
if not all stores are done. there are not-so-rarely channels that get stuck for weeks. or do not get a release at all. one wants to see see that eg. that core123 is available on macOS - but stock on Windows for $reasons. or that android456 is out on Google Play - but not on F-droid since weeksso, maybe a bit more neutral here:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I bet that if it is not a todo item it will be forgotten.
There is always the release progress issue on desktop, so if you want to know the state of the release, better look there directly. we could also establish that the latest release progress issue should be pinned for easier access.
I see the use case more in finding out fast, what core version was used based on ui version without checking the long UI changelog easily. for checking what is delayed there is the release progress issue on desktop.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if that is the gist, indeed on desktop that information is hard to find.
on android/ios we always add a "update to core123" or "using core123" to the end of each changelog entry, so we could just add a link to the changelog from
release.md
then.but anyways, it is also about what is doable, and yes, a concrete checkpoint is better than a vague additional sentence.
so, feel free to merge that in, it is definetely an improvement to add a hint to
release.md
. i was just wondering about the gist.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be honest, I don't know what hocuri and Holger thought when making it, this just my interpretation for what I'd use that file.