style: avoid horizontal scrollbars in chat list #4253
Merged
+10
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WofWca
force-pushed
the
wofwca/fix-horizontal-scrollbars-in-chatlist
branch
2 times, most recently
from
7e02910
to
4aa086b
Compare
The bug was likely introduced in 0e0d0b8, where scrollbars got wider on Windows. So if a contact has a long email or name, it would overflow the chat list in "search" mode. The new approach makes the widths less hard-coded and lets the browser handle widths.
WofWca
force-pushed
the
wofwca/fix-horizontal-scrollbars-in-chatlist
branch
from
4aa086b
to
dc30983
Compare
Simon-Laux
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug was likely introduced in 0e0d0b8,
where scrollbars got wider on Windows.
So if a contact has a long email or name, it would overflow
the chat list in "search" mode.
Before:
After:
I have tried to test this thoroughly, with the "verified" check-marks, and with the "last message at" text. Looks alright.
The new approach makes the widths less hard-coded and lets the browser handle widths.