Copy files to tmpdir #4604
Merged
Copy files to tmpdir #4604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New function to copy files to a tmp dir inside account dir. Files are copied to that dir and renamed to their original filename to assure they are handled appropriate in other applications
Simon-Laux
reviewed
Feb 6, 2025
Simon-Laux
approved these changes
Feb 6, 2025
|
One possible concern is whether account deletion still works on windows if you currently have an attachment open in a different program? |
The same for restarting the app with a file from tmp dir opened in some app. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #4498
resolves #4352
Files are copied to accounts/accountId/tmp/ before opening.
Files that have an ID from deduplication as name are copied to a folder with that name, to assure multiple files with same name do not conflict tmp/fileId/originalFilename.ext
On any start of the app all tmp dirs are deleted again
I didn't find any cases for second point in that issue "Make sure that the actual name of the file isn't shown to the user " - but that might also be checked in reviews