fix: a11y: improve tab order (navbar) #4672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WofWca
force-pushed
the
wofwca/rearrange-navbar-html
branch
from
fb76f30 to
102fe31
Compare
Draft
Simon-Laux
approved these changes
Feb 20, 2025
`__button` in BEM is conventionally used for children elements. `--` is more clear.
To add module.scss file later.
It's not specific to the navbar.
This ensures that the list of chats follows the search bar, and that the messages list follows the chat header. Closes #4225. This mostly moves code around, and simplifies some things (such as replacing `width: 30%` duplication) along the way. But it also changes the relative sizes of the "chat list" and the "chat" (main view) sections, to a ratio of 3:8 (before the "chat list" section was 30% of the window size). Otherwise, besides, of course, the tab order fix, this is not supposed to affect the behavior and the look of the app.
WofWca
force-pushed
the
wofwca/rearrange-navbar-html
branch
from
102fe31 to
b9646e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Toggle "hide whitespace" for easier review.
This ensures that the list of chats follows the search bar,
and that the messages list follows the chat header.
Closes #4225.
This mostly moves code around, and simplifies some things
(such as replacing
width: 30%duplication) along the way.But it also changes the relative sizes of the "chat list" and the
"chat" (main view) sections, to a ratio of 3:8
(before the "chat list" section was 30% of the window size).
Otherwise, besides, of course, the tab order fix,
this is not supposed to affect the behavior and the look of the app.
I testes a lot of things:
But there is still a chance that I missed something.