Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addressable address #11142

Merged
merged 6 commits into from
Jan 15, 2025
Merged

Addressable address #11142

merged 6 commits into from
Jan 15, 2025

Conversation

LeSim
Copy link
Member

@LeSim LeSim commented Dec 16, 2024

  • on rajoute le concerne AddressableColumnConcern au champ address -> il expose maintenant les colonnes code postal / commune / département / région
  • pour que ces colonnes soient remplis, il faut que la donnée address soit sauvegardée dans la colonne value_json, elle stockée dans data en ce moment
  • dans le champ address, le departement est stocké est sous forme department_code
  • AddressableColumnConcern est maintenant utilisé dans les champs rna / rnf / siret et address

pour les champs siret / rna / rnf / le departement est sauvé sous format departement_code et department_code grace au commit 366c02d et la donnée a été backfillée avec les taches populate_rnf_json_value / rna / siret

Du coup, on peut modifier le json_path du departement de $.departement_code -> $.department_code pour faire marcher la colonne partout.

puis

  • backfill des champs adresse pour remplir value_json

a discuter :

  • faisabilité de l'update direct des address value_json va passer
  • technique de maj des colonnes dans les pp a répéter pour les exports et les export_templates
  • AddressProxy se base encore sur departement_name, departement_code

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 54.83871% with 28 lines in your changes missing coverage. Please review.

Project coverage is 84.49%. Comparing base (48fccd6) to head (698dd40).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
.../migrate_export_address_and_linked_columns_task.rb 0.00% 13 Missing ⚠️
...export_template_address_and_linked_columns_task.rb 0.00% 12 Missing ⚠️
app/models/champs/address_champ.rb 71.42% 2 Missing ⚠️
...re_presentation_address_and_linked_columns_task.rb 94.11% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11142      +/-   ##
==========================================
- Coverage   84.55%   84.49%   -0.07%     
==========================================
  Files        1196     1200       +4     
  Lines       26300    26358      +58     
  Branches     4962     4962              
==========================================
+ Hits        22239    22270      +31     
- Misses       4061     4088      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LeSim LeSim force-pushed the addressable_address branch 4 times, most recently from c005b1d to 34385c3 Compare January 13, 2025 17:46
@LeSim LeSim marked this pull request as ready for review January 13, 2025 17:48
@LeSim LeSim force-pushed the addressable_address branch from 34385c3 to 9b8a6a5 Compare January 13, 2025 17:48
@LeSim LeSim changed the title WIP Addressable address Addressable address Jan 13, 2025
@LeSim LeSim force-pushed the addressable_address branch 3 times, most recently from 795c0f6 to d7a1dcd Compare January 14, 2025 15:38
@LeSim LeSim force-pushed the addressable_address branch from d7a1dcd to 698dd40 Compare January 15, 2025 09:45
@LeSim LeSim enabled auto-merge January 15, 2025 09:47
@LeSim LeSim added this pull request to the merge queue Jan 15, 2025
Merged via the queue into main with commit 6ca8ddb Jan 15, 2025
18 checks passed
@LeSim LeSim deleted the addressable_address branch January 15, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants