-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addressable address #11142
Merged
Merged
Addressable address #11142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11142 +/- ##
==========================================
- Coverage 84.55% 84.49% -0.07%
==========================================
Files 1196 1200 +4
Lines 26300 26358 +58
Branches 4962 4962
==========================================
+ Hits 22239 22270 +31
- Misses 4061 4088 +27 ☔ View full report in Codecov by Sentry. |
colinux
reviewed
Dec 16, 2024
LeSim
force-pushed
the
addressable_address
branch
4 times, most recently
from
January 13, 2025 17:46
c005b1d
to
34385c3
Compare
LeSim
force-pushed
the
addressable_address
branch
from
January 13, 2025 17:48
34385c3
to
9b8a6a5
Compare
LeSim
force-pushed
the
addressable_address
branch
3 times, most recently
from
January 14, 2025 15:38
795c0f6
to
d7a1dcd
Compare
colinux
approved these changes
Jan 15, 2025
spec/tasks/maintenance/migrate_procedure_presentation_address_and_linked_columns_task_spec.rb
Show resolved
Hide resolved
…ize column address (->, .) et departement -> department
…:Address_parts. Should I do something on AddressProxy
LeSim
force-pushed
the
addressable_address
branch
from
January 15, 2025 09:45
d7a1dcd
to
698dd40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AddressableColumnConcern
au champaddress
-> il expose maintenant les colonnes code postal / commune / département / régionvalue_json
, elle stockée dansdata
en ce momentdepartment_code
AddressableColumnConcern
est maintenant utilisé dans les champsrna
/rnf
/siret
etaddress
pour les champs siret / rna / rnf / le departement est sauvé sous format
departement_code
etdepartment_code
grace au commit 366c02d et la donnée a été backfillée avec les taches populate_rnf_json_value / rna / siretDu coup, on peut modifier le json_path du departement de
$.departement_code
->$.department_code
pour faire marcher la colonne partout.puis
value_json
a discuter :
departement_name
,departement_code