Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ETQ administrateur, je souhaite que les pdfs ne levent pas d'erreur de font #11206

Merged

Conversation

mfo
Copy link
Contributor

@mfo mfo commented Jan 14, 2025

crisp: https://app.crisp.chat/website/266ba25d-91d1-4774-b01f-a23ba63d662f/inbox/session_3eab7b74-cd1f-4ef8-81aa-da3d3621bf53/

prob

les pdf levent des erreurs sur la font Marianne

solution

en creusant, il semblerait que prawn 2.5.0 requiert pdfunk 1.8.x, cf: prawnpdf/prawn#1346
donc on force la version de pdfunk en attendant

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.56%. Comparing base (36148b7) to head (d9dd005).
Report is 19 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11206      +/-   ##
==========================================
- Coverage   84.59%   84.56%   -0.04%     
==========================================
  Files        1196     1196              
  Lines       26314    26298      -16     
  Branches     4968     4962       -6     
==========================================
- Hits        22260    22238      -22     
- Misses       4054     4060       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@colinux
Copy link
Member

colinux commented Jan 14, 2025

pas sur d'avoir pigé au vu de l'issue, t'as tenté d'upgrade pdfunk tout en downgrade prawn ? Si on garde le downgrade tu peux retirer pdfunk du gemfile ? (j'ai l'impression que c'est la meilleure chose à faire en attendant qu'ils releasent une version avec la bonne dep)

@mfo mfo force-pushed the US/downgrade-prawn-due-to-issue-1362 branch from 5037d24 to 7e544c1 Compare January 14, 2025 13:56
@mfo mfo force-pushed the US/downgrade-prawn-due-to-issue-1362 branch from 7e544c1 to d9dd005 Compare January 14, 2025 13:56
@mfo
Copy link
Contributor Author

mfo commented Jan 14, 2025

pas sur d'avoir pigé au vu de l'issue, t'as tenté d'upgrade pdfunk tout en downgrade prawn ? Si on garde le downgrade tu peux retirer pdfunk du gemfile ? (j'ai l'impression que c'est la meilleure chose à faire en attendant qu'ils releasent une version avec la bonne dep)

va pr le downgrade prawn en 2.4.0 qui devrait aussi regler le prob (par contre je ne reproduis pas chez moi, j'imagine que mac ou preview est plus tolérant a ce type de prob)

@mfo mfo enabled auto-merge January 14, 2025 14:38
@mfo mfo added this pull request to the merge queue Jan 14, 2025
Merged via the queue into demarches-simplifiees:main with commit 2bfd51e Jan 14, 2025
18 checks passed
@mfo mfo deleted the US/downgrade-prawn-due-to-issue-1362 branch January 14, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants