Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove mock mechanism #4764

Open
wants to merge 35 commits into
base: master
Choose a base branch
from
Open

Remove mock mechanism #4764

wants to merge 35 commits into from

Conversation

MosheEichler
Copy link
Contributor

Related Issues

fixes:

Description

@MosheEichler MosheEichler self-assigned this Jan 12, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2025

Changelog(s) in markdown:

  • Removed mocking mechanism in test-content command. #4764

@MosheEichler
Copy link
Contributor Author

MosheEichler commented Feb 10, 2025 •
edited
Loading

Content nightly
Content PR
SDK nightly

samuelFain
samuelFain reviewed Feb 19, 2025
View reviewed changes
Copy link
Contributor

@samuelFain samuelFain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please see my comments.
I also suggest running a content nightly OR a content PR that triggers a few TPBs with this sdk branch to make sure we don't break anything in the content build flow.

@MosheEichler
Copy link
Contributor Author

Looks good, please see my comments. I also suggest running a content nightly OR a content PR that triggers a few TPBs with this sdk branch to make sure we don't break anything in the content build flow.

I ran a nightly and a content build as you can see in this comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelFain samuelFain samuelFain left review comments

@thefrieddan1 thefrieddan1 thefrieddan1 approved these changes

@dantavori dantavori Awaiting requested review from dantavori dantavori is a code owner

@RosenbergYehuda RosenbergYehuda Awaiting requested review from RosenbergYehuda RosenbergYehuda is a code owner

@idovandijk idovandijk Awaiting requested review from idovandijk idovandijk is a code owner

@YuvHayun YuvHayun Awaiting requested review from YuvHayun YuvHayun is a code owner

@kobymeir kobymeir Awaiting requested review from kobymeir

@DeanArbel DeanArbel Awaiting requested review from DeanArbel

Assignees

@MosheEichler MosheEichler

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MosheEichler @thefrieddan1 @samuelFain