Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for pulling images from private registries #83

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mrBliss
Copy link

@mrBliss mrBliss commented Aug 6, 2021

Fixes #82.

pullImage now takes a PullOpts argument, which includes an optional
AuthConfig. For more details, see:
https://docs.docker.com/engine/api/v1.41/#section/Authentication

@mrBliss
Copy link
Author

mrBliss commented Aug 6, 2021

It seems this project has no CI. Before submitting this PR, I successfully compiled this branch with all stack-*.yaml files in this repo (hence the choice for base64-bytestring library over the newer base64 library, which does not support GHC 7.10, IIRC).

I didn't add a test, as it would require setting up a private Docker registry, which is quite the effort. However, I did successfully test it with a private registry (using Credentials).

@ocramz
Copy link
Contributor

ocramz commented Mar 1, 2024

@mrBliss @denibertovic the project now has CI, how can we move this PR forward?
BTW @denibertovic I'd be happy to help if you don't have the bandwidth. Thanks!

@denibertovic
Copy link
Owner

@ocramz Sure thing. If you can resolve the conflicts in a new PR I'd be happy to merge. Also at this point I think we would be ok to drop support for 7.10 if it's too big of a hassle to support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support URL Image Sources and Private Registries (esp. AWS ECR)
3 participants