Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pr/datalog rules #24

Closed
wants to merge 2 commits into from
Closed

Conversation

CharlesHD
Copy link

Okay so this is a first draw where I implement the ideas expressed in #23
I add :

  • a (reg-query-sub query-id query rules) form to reg-query-sub
  • a :rules attribute to query config map

@denistakeda
Copy link
Owner

@CharlesHD re-posh heavily depends on posh library. And posh supports only subset of datascript functionality (which is a subset of datomic functionality itself). Have you verified that it works?

@CharlesHD
Copy link
Author

Not yet, that's why it is a first draw. But my guess is it has high chance to work since posh.reagent/q is a direct call to datascript.core/q and rules work fine with Datascript.

I'll add and test a rule example in the todomvc if you are okay with that.

@denistakeda
Copy link
Owner

Sure, it would be great

@CharlesHD
Copy link
Author

OK. After some investigations, rules are broken in posh5 as stated in mpdairy/posh#23 . So that PR is bounded by some progression in posh. Too bad.

@denistakeda denistakeda closed this Nov 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants