Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(task): dependencies #26467

Merged
merged 39 commits into from
Nov 19, 2024
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
cb60623
feat(task): dependencies
dsherret Oct 22, 2024
526834d
Merge branch 'main' into feat_task_dependencies
bartlomieju Nov 14, 2024
7f2e2bd
support for description
bartlomieju Nov 14, 2024
8d02b99
simplify
bartlomieju Nov 14, 2024
9e16466
further refactor
bartlomieju Nov 14, 2024
ba70860
add a todo
bartlomieju Nov 14, 2024
1bddb7c
Merge branch 'main' into feat_task_dependencies
bartlomieju Nov 16, 2024
b835b45
add basic tests
bartlomieju Nov 16, 2024
9e206db
update tests
bartlomieju Nov 16, 2024
8e2cb55
add cross package test
bartlomieju Nov 16, 2024
e8a5459
fmt and lint
bartlomieju Nov 16, 2024
32b04fe
add failing test for 'diamond' dependencies
bartlomieju Nov 16, 2024
52762f9
update schema file
bartlomieju Nov 16, 2024
caedab6
Merge branch 'main' into feat_task_dependencies
bartlomieju Nov 17, 2024
ed367a2
change diamond dep test for now
bartlomieju Nov 17, 2024
05432d8
Merge branch 'main' into feat_task_dependencies
bartlomieju Nov 17, 2024
2e73474
feat: run task chains in topological order
marvinhagemeister Nov 18, 2024
efd9c80
fix: make clippy happy
marvinhagemeister Nov 18, 2024
71209f7
Merge branch 'main' into feat_task_dependencies
bartlomieju Nov 18, 2024
b54306b
fix: don't parse script value as task
marvinhagemeister Nov 18, 2024
b5978df
fix: remove accidentally committed fixture
marvinhagemeister Nov 18, 2024
89c5542
feat: parallelize tasks if possible
marvinhagemeister Nov 18, 2024
efbd227
fix: make clippy happy
marvinhagemeister Nov 18, 2024
d5c4dc6
this doesn't work
bartlomieju Nov 19, 2024
27d86a4
wip
bartlomieju Nov 19, 2024
b47c130
a
bartlomieju Nov 19, 2024
530ac3a
Merge branch 'main' into feat_task_dependencies
bartlomieju Nov 19, 2024
2317822
show which tasks we depend on
bartlomieju Nov 19, 2024
f537a2b
remove a clone
bartlomieju Nov 19, 2024
8e4e7d1
cleanup
bartlomieju Nov 19, 2024
903da22
remove TODO
bartlomieju Nov 19, 2024
52c2305
simplify a bit
bartlomieju Nov 19, 2024
9c60d6f
fix a test
bartlomieju Nov 19, 2024
245e813
Use refcell
dsherret Nov 19, 2024
b35e17a
add missing newline
bartlomieju Nov 19, 2024
c7f8c4b
Show cycle detection, move state into method call, extract function f…
dsherret Nov 19, 2024
45017a5
Remove marked now that we keep track of the path
dsherret Nov 19, 2024
b4f8593
Merge branch 'main' into feat_task_dependencies
bartlomieju Nov 19, 2024
f00edf1
remove todo
bartlomieju Nov 19, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -332,3 +332,6 @@ opt-level = 3
opt-level = 3
[profile.release.package.zstd-sys]
opt-level = 3

[patch.crates-io]
deno_config = { path = "../deno_config" }
8 changes: 2 additions & 6 deletions cli/args/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -868,12 +868,8 @@ impl CliOptions {
} else {
&[]
};
let config_parse_options = deno_config::deno_json::ConfigParseOptions {
include_task_comments: matches!(
flags.subcommand,
DenoSubcommand::Task(..)
),
};
let config_parse_options =
deno_config::deno_json::ConfigParseOptions::default();
let discover_pkg_json = flags.config_flag != ConfigFlag::Disabled
&& !flags.no_npm
&& !has_flag_env_var("DENO_NO_PACKAGE_JSON");
Expand Down
5 changes: 2 additions & 3 deletions cli/lsp/language_server.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3629,9 +3629,8 @@ impl Inner {
deno_json_cache: None,
pkg_json_cache: None,
workspace_cache: None,
config_parse_options: deno_config::deno_json::ConfigParseOptions {
include_task_comments: false,
},
config_parse_options:
deno_config::deno_json::ConfigParseOptions::default(),
additional_config_file_names: &[],
discover_pkg_json: !has_flag_env_var("DENO_NO_PACKAGE_JSON"),
maybe_vendor_override: if force_global_cache {
Expand Down
Loading