-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Support include/exclude in github action #135
Merged
Merged
Changes from 7 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
07a1efc
Support include/exclude
osdiab 66d75c4
Update action yml for include/exclude params
osdiab 5661567
export normalize
osdiab 82e6ea9
update bundle
osdiab a87c7c6
test console log
osdiab 5079fc6
more debugging
osdiab 8ecc1c8
update behavior
osdiab c7cfd18
use getMultilineInput
arnauorriols 1824014
Use getMultilineInput
arnauorriols ed94210
fmt
arnauorriols 7c060a1
fixes
arnauorriols a166ee4
update docs
arnauorriols File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
export { parseEntrypoint } from "./entrypoint.ts"; | ||
export { API, APIError } from "./api.ts"; | ||
export { walk } from "./walk.ts"; | ||
export { fromFileUrl, resolve } from "../../deps.ts"; | ||
export { fromFileUrl, resolve, normalize } from "../../deps.ts"; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Newline separated strings is the defacto-standard workaround to express arrays in GH action parameters.
core.getMultilineInput()
handles splitting and trimming for you.It's preferrable as there might be array parameters we want to add in the future that might not play as well with the comma-separated approach.