Add flush method to ensure frame is correctly written #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the underlying stream is buffered (i.e: TlsStream<TcpStream>) calling write_frame is not enough to be guaranteed that data is pushed down to the last stream (i.e: on the network in case of TlsStream<TcpStream>). Currently there is no way to force flush the data on the stream, so write_frame call may never push the data. https://docs.rs/tokio-rustls/latest/tokio_rustls/index.html#why-do-i-need-to-call-poll_flush The commit introduce a flush method, to allow the user of the lib to ensure all data is correctly pushed down.
MokerWill
pushed a commit
to MokerWill/fastwebsockets
that referenced
this pull request
Jan 5, 2025
When the underlying stream is buffered (i.e: TlsStream<TcpStream>) calling write_frame is not enough to be guaranteed that data is pushed down to the last stream (i.e: on the network in case of TlsStream<TcpStream>). Currently there is no way to force flush the data on the stream, so write_frame call may never push the data. https://docs.rs/tokio-rustls/latest/tokio_rustls/index.html#why-do-i-need-to-call-poll_flush The commit introduce a flush method, to allow the user of the lib to ensure all data is correctly pushed down. (cherry picked from commit 4f274f4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the underlying stream is buffered (i.e: TlsStream) calling write_frame is not enough to be guaranteed that data is pushed down to the last stream (i.e: on the network in case of TlsStream).
https://docs.rs/tokio-rustls/latest/tokio_rustls/index.html#why-do-i-need-to-call-poll_flush
Currently there is no way to force flush the data on the stream, so write_frame call may never push the data.
So one can call write_frame and wait for a response that will never come as the other peer never received it.
The PR introduce a flush method, to allow the user of the lib to ensure all data is correctly pushed down.
see this issue for more information erebe/wstunnel#360