Rolling to V8 12.1.285.18

[denobot]

No description provided.

[littledivy]

Changes:

• v8::ScriptCompiler size increased by 3 words with v8::ScriptCompiler::CompilationDetails. @littledivy
• v8::ObjectTemplate::SetAccessor & v8::ObjectTemplate::SetAccessorProperty signature changed and also deprecated. @littledivy
• v8::Context::SetContinuationPreservedEmbedderData deprecated. Use v8::Isolate::GetContinuationPreservedEmbedderData instead. @littledivy
• GetStalledTopLevelAwaitMessage deprecated. Use GetStalledTopLevelAwaitMessages instead. @littledivy
• v8::Isolate::AttachCppHeap deprecated. Set the heap on Isolate creation using CreateParams instead. @littledivy
• v8::ScriptOrigin deprecated. Use constructor without the isolate. @bartlomieju
• v8::SnapshotCreator is deprecated. Use the version that passes CreateParams instead. @bartlomieju
• v8::Isolate assertion failures. @littledivy

[littledivy]

Relevant diff in V8:

-  static const int kBuiltinTier0EntryTableOffset =
-      kVariousBooleanFlagsOffset + 8;
+  static const int kErrorMessageParamOffset =
+      kVariousBooleanFlagsOffset + kNumberOfBooleanFlags;
+  static const int kBuiltinTier0EntryTableOffset = kErrorMessageParamOffset +
+                                                   kErrorMessageParamSize +
+                                                   kTablesAlignmentPaddingSize;

[littledivy]

Failing test value_serializer_not_implemented:

#
# Fatal error in ../../../v8/src/execution/isolate.cc, line 1839
# Debug check failed: !has_exception().
#
#
#
#FailureMessage Object: 0x170211878
==== C stack trace ===============================
    0   test_api-f90cf292ca91bb27           0x00000001004798d4 v8::base::debug::StackTrace::StackTrace() + 24
    1   test_api-f90cf292ca91bb27           0x000000010047ff94 v8::platform::(anonymous namespace)::PrintStackTrace() + 116
    2   test_api-f90cf292ca91bb27           0x0000000100462544 V8_Fatal(char const*, int, char const*, ...) + 268
    3   test_api-f90cf292ca91bb27           0x0000000100461fec std::Cr::enable_if<!std::is_function<std::Cr::remove_pointer<char>::type>::value && !std::is_enum<char>::value && has_output_operator<char, v8::base::CheckMessageStream>::value, std::Cr::basic_string<char, std::Cr::char_traits<char>, std::Cr::allocator<char>>>::type v8::base::PrintCheckOperand<char>(char) + 0
    4   test_api-f90cf292ca91bb27           0x000000010081ada4 v8::internal::Isolate::Throw(v8::internal::Tagged<v8::internal::Object>, v8::internal::MessageLocation*) + 2276
    5   test_api-f90cf292ca91bb27           0x0000000100535e34 v8::ValueSerializer::Delegate::GetSharedArrayBufferId(v8::Isolate*, v8::Local<v8::SharedArrayBuffer>) + 272
    6   test_api-f90cf292ca91bb27           0x000000010045815c v8__ValueSerializer__Delegate::GetSharedArrayBufferId(v8::Isolate*, v8::Local<v8::SharedArrayBuffer>) + 116
    7   test_api-f90cf292ca91bb27           0x0000000100efdde8 v8::internal::ValueSerializer::WriteJSArrayBuffer(v8::internal::Handle<v8::internal::JSArrayBuffer>) + 208
    8   test_api-f90cf292ca91bb27           0x0000000100efa7e4 v8::internal::ValueSerializer::WriteJSReceiver(v8::internal::Handle<v8::internal::JSReceiver>) + 708
    9   test_api-f90cf292ca91bb27           0x000000010053621c v8::ValueSerializer::WriteValue(v8::Local<v8::Context>, v8::Local<v8::Value>) + 184
    10  test_api-f90cf292ca91bb27           0x000000010043ad20 v8__ValueSerializer__WriteValue + 84
    11  test_api-f90cf292ca91bb27           0x00000001003f76c4 v8::value_serializer::ValueSerializerHelper::write_value::h2c1ae2b6a7e9b100 + 76
    12  test_api-f90cf292ca91bb27           0x00000001003ef284 v8::value_serializer::ValueSerializer::write_value::h9d1625a18830651a + 76
    13  test_api-f90cf292ca91bb27           0x000000010030c938 test_api::value_serializer_not_implemented::h5d0935005ba9f685 + 1600
    14  test_api-f90cf292ca91bb27           0x0000000100082574 _ZN8test_api32value_serializer_not_implemented28_$u7b$$u7b$closure$u7d$$u7d$17h2ef2aa2292d94796E + 24
    15  test_api-f90cf292ca91bb27           0x0000000100009e88 core::ops::function::FnOnce::call_once::hcc5e57b523d822c3 + 20
    16  test_api-f90cf292ca91bb27           0x00000001003e11a0 test::__rust_begin_short_backtrace::hcd11bf66f9eb4206 + 28
    17  test_api-f90cf292ca91bb27           0x00000001003e0120 _ZN4test8run_test14run_test_inner28_$u7b$$u7b$closure$u7d$$u7d$17h56046d2cd440b9aaE + 560
    18  test_api-f90cf292ca91bb27           0x00000001003b21f0 std::sys_common::backtrace::__rust_begin_short_backtrace::h96ff6c383309bf0d + 160
    19  test_api-f90cf292ca91bb27           0x00000001003b7304 _ZN4core3ops8function6FnOnce40call_once$u7b$$u7b$vtable.shim$u7d$$u7d$17hefe3d0357af394e1E + 128
    20  test_api-f90cf292ca91bb27           0x0000000102a8a244 std::sys::unix::thread::Thread::new::thread_start::h999abeaf027c3bba + 48
    21  libsystem_pthread.dylib             0x0000000188b39034 _pthread_start + 136
    22  libsystem_pthread.dylib             0x0000000188b33e3c thread_start + 8
Process 73572 stopped
* thread #15, name = 'value_serializer_not_implemented', stop reason = EXC_BREAKPOINT (code=1, subcode=0x100478024)
    frame #0: 0x0000000100478024 test_api-f90cf292ca91bb27`::Abort() at platform-posix.cc:699:7 [opt]
warning: test_api-f90cf292ca91bb27 was compiled with optimization - stepping may behave oddly; variables may not be available.
(lldb) up
frame #1: 0x0000000100462550 test_api-f90cf292ca91bb27`V8_Fatal(char const*, int, char const*, ...) + 280
test_api-f90cf292ca91bb27`V8_Dcheck:
->  0x100462550 <+0>:        adrp   x8, 13670
    0x100462554 <-18241420>: ldr    x3, [x8, #0x148]
    0x100462558 <-18241416>: br     x3

test_api-f90cf292ca91bb27`v8::base::detail::PrintToString<void*>:
    0x10046255c <+0>:        sub    sp, sp, #0x160
(lldb) up
frame #2: 0x0000000100461fec test_api-f90cf292ca91bb27`::FatalImpl() - 18446744069409988627 [opt]
test_api-f90cf292ca91bb27`v8::base::PrintCheckOperand<char>:
->  0x100461fec <+0>:        mov    x1, x0
    0x100461ff0 <-18242800>: mov    x0, x8
    0x100461ff4 <-18242796>: b      0x100461ff8               ; v8::base::(anonymous namespace)::PrettyPrintChar(int)

test_api-f90cf292ca91bb27`v8::base::(anonymous namespace)::PrettyPrintChar:
    0x100461ff8 <+0>:        sub    sp, sp, #0x180
(lldb) up
frame #3: 0x000000010081ada4 test_api-f90cf292ca91bb27`::Throw() at isolate.cc:1839:3 [opt]
(lldb) up
frame #4: 0x0000000100535e34 test_api-f90cf292ca91bb27`::GetSharedArrayBufferId() at api.cc:3502:14 [opt]
(lldb) up
frame #5: 0x000000010045815c test_api-f90cf292ca91bb27`::GetSharedArrayBufferId() at binding.cc:3259:45
(lldb) up
frame #6: 0x0000000100efdde8 test_api-f90cf292ca91bb27`::WriteJSArrayBuffer() at value-serializer.cc:937:40 [opt]
(lldb) up
frame #7: 0x0000000100efa7e4 test_api-f90cf292ca91bb27`::WriteJSReceiver() at value-serializer.cc:617:14 [opt]
(lldb) up
frame #8: 0x000000010053621c test_api-f90cf292ca91bb27`::WriteValue() at api.cc:3560:45 [opt]
(lldb) up
frame #9: 0x000000010043ad20 test_api-f90cf292ca91bb27`::v8__ValueSerializer__WriteValue() at binding.cc:3323:36
(lldb) up
frame #10: 0x00000001003f76c4 test_api-f90cf292ca91bb27`v8::value_serializer::ValueSerializerHelper::write_value::h2c1ae2b6a7e9b100(self=0x00006000002848d0, context=Local<v8::data::Context> @ 0x0000000170211e18, value=Local<v8::data::Value> @ 0x0000000170211e28) at value_serializer.rs:369:7
   366 	    value: Local<Value>,
   367 	  ) -> Option<bool> {
   368 	    unsafe {
-> 369 	      v8__ValueSerializer__WriteValue(
   370 	        self.get_cxx_value_serializer(),
   371 	        context,
   372 	        value,
(lldb) up
frame #11: 0x00000001003ef284 test_api-f90cf292ca91bb27`v8::value_serializer::ValueSerializer::write_value::h9d1625a18830651a(self=0x0000000170212268, context=Local<v8::data::Context> @ 0x0000000170211e68, value=Local<v8::data::Value> @ 0x0000000170211e78) at value_serializer.rs:511:5
   508 	    context: Local<Context>,
   509 	    value: Local<Value>,
   510 	  ) -> Option<bool> {
-> 511 	    self.value_serializer_heap.write_value(context, value)
   512 	  }
   513 	}
(lldb) up
frame #12: 0x000000010030c938 test_api-f90cf292ca91bb27`test_api::value_serializer_not_implemented::h5d0935005ba9f685 at test_api.rs:8104:14
   8101	  .unwrap();
   8102	  let mut value_serializer = Custom2Value::serializer(scope);
   8103	  assert_eq!(value_serializer.write_value(context, objects), None);
-> 8104	
   8105	  assert!(scope.exception().is_some());
   8106	  assert!(scope.stack_trace().is_some());
   8107	  assert!(scope.message().is_some());
(lldb) up
frame #13: 0x0000000100082574 test_api-f90cf292ca91bb27`test_api::value_serializer_not_implemented::_$u7b$$u7b$closure$u7d$$u7d$::h2ef2aa2292d94796((null)=0x000000017021275e) at test_api.rs:8083:39
   8080	
   8081	#[test]
   8082	fn value_serializer_not_implemented() {
-> 8083	  let _setup_guard = setup::parallel_test();
   8084	  let isolate = &mut v8::Isolate::new(Default::default());
   8085	
   8086	  let scope = &mut v8::HandleScope::new(isolate);
(lldb) ^D