Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Bring back deprecated v8::String API #1694

Merged
merged 6 commits into from
Feb 7, 2025

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented Feb 6, 2025

Brings back String APIs removed in #1692
and renamed the new APIs to have _v2 suffix.

src/binding.cc Outdated Show resolved Hide resolved
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@bartlomieju bartlomieju merged commit 79c94a9 into main Feb 7, 2025
14 checks passed
@bartlomieju bartlomieju deleted the bring_back_old_string_api branch February 7, 2025 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants