Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(fs): do not write files in source tree during test #6236

Merged
merged 9 commits into from
Dec 23, 2024

Conversation

jbronder
Copy link
Contributor

@jbronder jbronder commented Dec 5, 2024

This pull request addresses the issue of files and directories being created and written into the source tree while testing functions in the fs package. Creation of temporary directories were incorporated into the existing tests where applicable.

Fixes #5358 .

@jbronder jbronder requested a review from kt3k as a code owner December 5, 2024 00:02
@CLAassistant
Copy link

CLAassistant commented Dec 5, 2024

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the fs label Dec 5, 2024
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.34%. Comparing base (b1b8279) to head (652ba92).
Report is 35 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6236      +/-   ##
==========================================
- Coverage   96.52%   96.34%   -0.18%     
==========================================
  Files         534      547      +13     
  Lines       40976    41661     +685     
  Branches     6134     6313     +179     
==========================================
+ Hits        39551    40138     +587     
- Misses       1383     1481      +98     
  Partials       42       42              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution! Also thanks for looking into the errors on windows

@kt3k kt3k changed the title test(fs): do not write files in source tree during test (#5358) test(fs): do not write files in source tree during test Dec 23, 2024
@kt3k kt3k merged commit 9bf17e4 into denoland:main Dec 23, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test(fs): do not write files in source tree during test
5 participants