-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(fs): do not write files in source tree during test #6236
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6236 +/- ##
==========================================
- Coverage 96.52% 96.34% -0.18%
==========================================
Files 534 547 +13
Lines 40976 41661 +685
Branches 6134 6313 +179
==========================================
+ Hits 39551 40138 +587
- Misses 1383 1481 +98
Partials 42 42 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for your contribution! Also thanks for looking into the errors on windows
This pull request addresses the issue of files and directories being created and written into the source tree while testing functions in the
fs
package. Creation of temporary directories were incorporated into the existing tests where applicable.Fixes #5358 .