Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Capybara infra to match Caseflow #1150

Merged
merged 29 commits into from
Dec 17, 2019
Merged

Update Capybara infra to match Caseflow #1150

merged 29 commits into from
Dec 17, 2019

Conversation

pkarman
Copy link
Contributor

@pkarman pkarman commented Dec 12, 2019

connects #1148

Description

Updates several gems and spec configuration to match Caseflow, chiefly the Capybara and Sniffybara gems for headless browser specs.

This PR disables 3 download tests that are failing to run on CircleCI but run fine locally. To test them locally, pass the --tag download flag to rspec.

@pkarman pkarman self-assigned this Dec 12, 2019
require "capybara"
# The TZ variable controls the timezone of the browser in capybara tests, so we always define it.
# By default (esp for CI) we use Eastern time, so that it doesn't matter where the developer happens to sit.
#ENV["TZ"] ||= "America/New_York"
Copy link
Contributor Author

@pkarman pkarman Dec 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

currently disabled but we should enable and test for it. See #1157

Copy link
Contributor

@alisan16 alisan16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than duplicating the same files from the caseflow repo to caseflow-efolder, should we consider moving shared logic to caseflow-commons?

Non-blocking comment, just curious about what you're thinking of for that repo moving forward

@pkarman
Copy link
Contributor Author

pkarman commented Dec 17, 2019

Only one file came from caseflow (spec/support/capybara.rb) and I had to change it a bit to support downloads.

@pkarman pkarman merged commit c61d80c into master Dec 17, 2019
@pkarman pkarman deleted the pek-headless-tests branch December 17, 2019 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants