-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Capybara infra to match Caseflow #1150
Conversation
This reverts commit bc8a2e9.
a23d403
to
c949fe5
Compare
require "capybara" | ||
# The TZ variable controls the timezone of the browser in capybara tests, so we always define it. | ||
# By default (esp for CI) we use Eastern time, so that it doesn't matter where the developer happens to sit. | ||
#ENV["TZ"] ||= "America/New_York" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
currently disabled but we should enable and test for it. See #1157
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than duplicating the same files from the caseflow repo to caseflow-efolder, should we consider moving shared logic to caseflow-commons?
Non-blocking comment, just curious about what you're thinking of for that repo moving forward
Only one file came from caseflow ( |
connects #1148
Description
Updates several gems and spec configuration to match Caseflow, chiefly the Capybara and Sniffybara gems for headless browser specs.
This PR disables 3 download tests that are failing to run on CircleCI but run fine locally. To test them locally, pass the
--tag download
flag to rspec.