Will/appeals 63607 #23488

buddylove954 · 2024-11-13T15:32:13Z

Resolves Changing eligibility for a contention on a Caseflow originating claim review in VBMS causes "Something went wrong" when opening the Edit page

Description

modified decision review update to include an epe

Acceptance Criteria

"Edit Issues" page opens and you can see all the request issues

Tests

Test Coverage

Did you include any test coverage for your code? Check below:

RSpec

Code Climate

Your code does not add any new code climate offenses? If so why?

No new code climate issues added

…er (#20569) * added skeleton for api route * removed duplicate code * removed development envs for api and moved to creating an ApiKey * removing any changes to development.rb * removed extra auth code * removed before action --------- Co-authored-by: TuckerRose <[email protected]>

…ute & Controller (#20601) * APPEALS-38232 - renamed controller to AC req, added decision_review_created_error endpoint, added decision_review_created_error method, and added RSpec for new method * APPEALS-38232 - add comments to RSpec

* initial Events migration and model creation * created model for DecisionReviewCreatedEvent * updated comment with example * added spec for DRCE model * APPEALS-36684 created event_records migration and added polymorphic associations to specific models, and added rspec for the event_record model * APPEALS-36684 - Updated RSpec tests and updated variables and got unhappy path to pass * cleaned lint * saving DRCE spec changes * fixed spec test * changed has_many to has_one * updated event model spec * added validation for ER poly associations * changed association to has_one * added new method and updated tests * added foreign key after running checks * some PR comment changes * refactored methods in EventConcern --------- Co-authored-by: Jonathan Tsang <[email protected]> Co-authored-by: Enrilo Ugalde <[email protected]>

* fixed migration to update existing events table * rollbacked to fix schema * schema fixes --------- Co-authored-by: TuckerRose <[email protected]>

* APPEALS-38926 - Created DecisionReviewCreatedError Service Class, added logic for handling service error, updated DecisonReviewCreatedController, and DecisionReviewCreatedController spec, with the updated service logic * APPEALS-38926- created RSpec Test for DecisionReviewCreatedError Service Class and edited the Rails.logger for the service class * APPEALS-38926 Added new info column to update transaction and added it to the RSpec test * APPEALS-38926 - added comments to the Service Class * APPEALS-38926 - Code Changes from TL Code Review, added rescues and fails * APPEALS-38926 - fixed lint

* created new service class * add rspec test cases * service class methods * controller action and spec * controller update * CC fixes * removed accidental line * changed to find_or_create_by * reworked error for redis lock * additional rspec for controller * fixed test * rspec fix * delete lock key afterwards * moved Event creation back into lock block --------- Co-authored-by: Jonathan Tsang <[email protected]>

… create user if needed (#20838) * added user creation class & test * removed extra lines * add comment to class * added context for args from avro --------- Co-authored-by: Jonathan Tsang <[email protected]>

* APPEALS-39664 - Created updated_vacols_on_optin module class, and removed extra private * APPEALS-39664 - created UpdatedVacolsOnOptin module, RSpec file, as well as sudo code for SOC and SSOC optin check in main service class DecisionReviewCreated * APPEALS-39664 - Created RSpec Test - PASS, Updated method name. * APPEALS-39664 - Added Error Handling to Sub Service Class * APPEALS-39664 - Removed un-needed comments * APPEALS-39664 - added include for the module UpdateVacolsOnOptin inside decision_review_created service * APPEALS-39664 - Added Custom Error , and updated all .perform! to .process! * APPEALS-39664 - Updated RSpec Test to reflect changes - all pass * Updated comment for decision_review_created Service Class

* Created attribute for failed claims on event and displaying failed claim * passing all failed events back to serializer * added controller tests for failed_claims and added class method for finding claims on events * renamed failed_claims to claim_errors --------- Co-authored-by: TuckerRose <[email protected]>

…reate Intake (#20967) * APPEALS-40954 - Added Sudo Code for CreateIntake Logic * APPEALS-40954 - added logic to CreateIntake module * APPEALS-40954 - added Create Intake spec with error handling - All pass * APPEALS-40954 - Added CreateIntake Module to DecisionReviewCreated Main Service * APPEALS-40954 - updated folder name and namespace * APPEALS-40954 - Updated RSpec to match folder * APPEALS-40954- Upated decision review created servie include to match folder * Fixed failing test due to folder structure change

* Added new veteran creation module * saving test changes * rspec * fixed datetime assign * renamed var --------- Co-authored-by: Jonathan Tsang <[email protected]>

* APPEALS-40950 - update var veteran to vbms_veteran * updated private method in controller to match happy path params dcr to drc

…aimant if needed (#21044) * created service class and basic unit tests * added conditionals for veteran claimants and will create veteran claimant now * modified create claimant to use eventing data * change to a class * creating claimant correctly * test fixes * removed old comments * fixed type for veteran_is_not_claimant * changed specs to match pulling out hash params and removed event.reference id * moved back to dot notation * updated comments * fixed create claimant issue * updated process to use bang method and returning claimant --------- Co-authored-by: TuckerRose <[email protected]>

…21108) * moved metricsService call to top of method * modified rspec case * moved metric logging spec case higher up --------- Co-authored-by: Jonathan Tsang <[email protected]>

…087-36678

#21167)

* added interface + parser class * edited veteran parse methods * renamed var to "payload" * started refactor * more refactor + rspec * added EPE attr * dateTime conversions * added class comments * rubocop lint changes * fixed test case --------- Co-authored-by: Jonathan Tsang <[email protected]>

* APPEALS-41931 - Created create_ep_establishment file and class * APPEALS-41931 - added process! method that creates epe from payload * APPEALS-41931 - added logic for EventRecord being created and error handling * APPEALS-41931 - added comments to process method * APPEALS-41931 - set up rspec test * APPEALS-41931 - removed lint * APPEALS-41931-created Rspec and Test Pass * APPEALS-41931 - cleaned lint and added error test 100% code coverage * APPEALS-41931- fixed lint * APPEALS-41931- fixed lint and fixed %100 code cov * APPEALS-41931 - cleaned up lint and warn for Service Class * APPEALS-41931 - Added CreateEpEstablishment.process! to the decision_review_created Parent Service Class * APPEALS-41931 - refactor code to implement new parser * fixed linting issues * APPEALS-41931 - Updated Comments for CreateEpEstablishment * APPEALS-41931 - moved logical date int to parser and refactored code in Class and RSepc * edits

* added an error and commented out call for createclaim * added new parser logic * merge request changes * fixed rubocop issues and added checks for claim review attributes --------- Co-authored-by: TuckerRose <[email protected]>

…d add additional parser methods (#21294) * APPEALS-42631 - create example.json * APPEALS-42631 - implemented example_response and load_example method and works as expected * APPEALS-42631 - created RSpec for DecisionReviewCreatedParser * APPEALS-42631 - Refactored parser and Added RSpec for current praser * APPEALS-42631 - added methods to parser for intake, claimant, and claim_review and added matching rspec for new methods * APPEALS-42631 - updated code per TL Comments * APPEALS-421631- added additional comments and fixing lint

* initial commit * implementation & error * renamed method * rspec * saving refactor progress * finished refactoring class * added comment * minor parser/rspec updates --------- Co-authored-by: Jonathan Tsang <[email protected]>

* added RI parser methods to rspec * updated config for Consumer --------- Co-authored-by: Jonathan Tsang <[email protected]>

…cords (#21334) * updated decision review created to uncomment actions and updated specs * remove binding.pry * removed comments * fixed a bunch of broken tests * fixed last broken tests * fixed params for methods and specs --------- Co-authored-by: TuckerRose <[email protected]>

…ntedRecord (#21382) * APPEALS-43446 - renamed columns for backfill record to evented record migrate and rollback work as intended * APPEALS-43446 replaced all backfill_record with evented_record within the models associations and updated Rspec tests * APPEALS-43446 fixed error message

* fixed test and refactored controller * saving changes * init commit passing all the way to request_issues * all pass and functions as expected * lint * lint * updated initializer to use deep_symbolize_keys * updated headers to be more dry * added missing Intake attributes * fixed failing tests * updated createIntake test * fixed veteran rspec * fixed RI test * APPEALS-43446- Change name of BackfillRecord polymorphic model to EventedRecord (#21382) * APPEALS-43446 - renamed columns for backfill record to evented record migrate and rollback work as intended * APPEALS-43446 replaced all backfill_record with evented_record within the models associations and updated Rspec tests * APPEALS-43446 fixed error message * updated intake * modified intake --------- Co-authored-by: Jonathan Tsang <[email protected]>

codeclimate · 2024-11-13T15:47:09Z

Code Climate has analyzed commit 6b3d977 and detected 0 issues on this pull request.

View more on Code Climate.

spec/feature/intake/higher_level_review/edit_spec.rb

nkutub · 2024-11-13T16:52:52Z

app/models/request_issues_update_event.rb

@@ -173,7 +174,10 @@ def process_ineligible_to_eligible_issues!
      parser_issue = Events::DecisionReviewUpdated::DecisionReviewUpdatedIssueParser.new(issue_data)
      request_issue = find_request_issue(parser_issue)
      before_data = request_issue.attributes
-      update_request_issue!(request_issue, parser_issue)
+      epe = EndProductEstablishment.find_by(


why are you finding EPE its being passed in at the class level ?

nkutub · 2024-11-13T16:53:41Z

app/models/request_issues_update_event.rb

@@ -94,7 +94,7 @@ def process_withdrawn_issues!
  end

  # rubocop:disable Metrics/MethodLength
-  def update_request_issue!(request_issue, parser_issue)
+  def update_request_issue!(request_issue, parser_issue, epe = nil)


why are you passing in epe its assigned as @epe in initializer

nkutub · 2024-11-13T16:55:07Z

spec/models/request_issues_update_event_spec.rb

@@ -63,6 +64,41 @@
    end
  end

+  let(:valid_parser_issue) do


what is the point of this ? we already have let(:parser_issue)

we were missing some data points and I didn't want to modify the parser_issue

please update the original parse to include the missing items , there is no need to create another one

This is updated, I think we need to update to feature/APREQ-97 match main

nkutub · 2024-11-13T16:55:58Z

spec/models/request_issues_update_event_spec.rb

+        event.update_request_issue!(request_issue, valid_parser_issue, nil)
+
+        request_issue.reload
+        expect(request_issue.end_product_establishment_id).to eq(request_issue.end_product_establishment_id)


this is testing nothing... you need to check this value before and after the update

nkutub · 2024-11-13T16:57:30Z

spec/models/request_issues_update_event_spec.rb

@@ -353,4 +389,41 @@
      expect(subject.processed_at).to eq(parser.end_product_establishment_last_synced_at)
    end
  end
+
+  describe "#update_request_issue!" do


I requested that you add a test to test the assignment of each field on the request issue update...

added that spec

jtsangVA

How does this relate to the bug outlined in the JIRA story?

buddylove954 and others added 30 commits January 24, 2024 10:28

added migration, scopes and specs for events (#20707)

c91ddf8

* fixed migration to update existing events table * rollbacked to fix schema * schema fixes --------- Co-authored-by: TuckerRose <[email protected]>

Merge branch 'master' into feature/APPEALS-28087-36678

580f725

APPEALS-39663 Create CreateUserOnEvent service class and add logic to…

cea711f

… create user if needed (#20838) * added user creation class & test * removed extra lines * add comment to class * added context for args from avro --------- Co-authored-by: Jonathan Tsang <[email protected]>

Jonathan/appeals 40950 (#20965)

fd26a8a

* Added new veteran creation module * saving test changes * rspec * fixed datetime assign * renamed var --------- Co-authored-by: Jonathan Tsang <[email protected]>

APPEALS-40950 - update var veteran to vbms_veteran (#21050)

c4d1a49

* APPEALS-40950 - update var veteran to vbms_veteran * updated private method in controller to match happy path params dcr to drc

APPEALS-41968 Modify Issues Endpoints & Update Metric Service Logic (#…

f6a58fa

…21108) * moved metricsService call to top of method * modified rspec case * moved metric logging spec case higher up --------- Co-authored-by: Jonathan Tsang <[email protected]>

Resolved merge conflicts while merging master into feature/APPEALS-28…

3efde93

…087-36678

Resolved merge conflicts while merging master into feature/APPEALS-28… (

a0f439f

#21167)

Will/appeals 41929 (#21205)

79cef69

* added an error and commented out call for createclaim * added new parser logic * merge request changes * fixed rubocop issues and added checks for claim review attributes --------- Co-authored-by: TuckerRose <[email protected]>

Merge branch 'master' into feature/APPEALS-28087-36678

7f82f6e

APPEALS-41934 (#21251)

57302b7

* initial commit * implementation & error * renamed method * rspec * saving refactor progress * finished refactoring class * added comment * minor parser/rspec updates --------- Co-authored-by: Jonathan Tsang <[email protected]>

added RI parser methods to rspec (#21322)

b538a70

* added RI parser methods to rspec * updated config for Consumer --------- Co-authored-by: Jonathan Tsang <[email protected]>

redo init commit

ff161fd

updated imp. logic

e018f1d

attorney widget fix

62397be

buddylove954 added 3 commits November 8, 2024 14:54

added unit tests and started on feature test wip

904b578

merged in main

fdb9488

wip

34fcef8

buddylove954 self-assigned this Nov 13, 2024

buddylove954 requested a review from nkutub November 13, 2024 16:10

removed debug calls

d83be11

nkutub reviewed Nov 13, 2024

View reviewed changes

spec/feature/intake/higher_level_review/edit_spec.rb Show resolved Hide resolved

nkutub reviewed Nov 13, 2024

View reviewed changes

buddylove954 added 3 commits November 13, 2024 13:03

fixed unit tests, commented out feature test(wip)

e3f51af

remove gemfile changes

62d2f5b

revert lock file

866bd71

buddylove954 marked this pull request as ready for review November 13, 2024 18:34

jtsangVA reviewed Nov 13, 2024

View reviewed changes

buddylove954 added 10 commits November 13, 2024 16:31

feature test done but still showing 500 error

58d05dd

removed debugging

d5b5400

removed comments

cabe3b7

code climate fixes

813caa8

more code climate fixes

7c09fa5

Merge branch 'main' into will/APPEALS-63607

f2217f3

removed comments

ca66a9f

removed valid parser

72e3f8c

code climate skip

411eae8

reove abcsize check

6b3d977

buddylove954 changed the base branch from main to feature/APREQ-97 November 15, 2024 13:38

buddylove954 changed the base branch from feature/APREQ-97 to main November 15, 2024 17:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Will/appeals 63607 #23488

Will/appeals 63607 #23488

buddylove954 commented Nov 13, 2024 •

edited

Loading

codeclimate bot commented Nov 13, 2024 •

edited

Loading

nkutub Nov 13, 2024

buddylove954 Nov 13, 2024

nkutub Nov 13, 2024

buddylove954 Nov 13, 2024

nkutub Nov 13, 2024

buddylove954 Nov 13, 2024

nkutub Nov 14, 2024

buddylove954 Nov 15, 2024

nkutub Nov 13, 2024

nkutub Nov 13, 2024

buddylove954 Nov 13, 2024

jtsangVA left a comment

Will/appeals 63607 #23488

Are you sure you want to change the base?

Will/appeals 63607 #23488

Conversation

buddylove954 commented Nov 13, 2024 • edited Loading

Description

Acceptance Criteria

Tests

Test Coverage

Code Climate

codeclimate bot commented Nov 13, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jtsangVA left a comment

Choose a reason for hiding this comment

buddylove954 commented Nov 13, 2024 •

edited

Loading

codeclimate bot commented Nov 13, 2024 •

edited

Loading