Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ki/APPEALS-42573 - Correspondence and Appeal Tasks: Add tasks to linked appeals: Add task modal #23509

Draft
wants to merge 11 commits into
base: feature/APPEALS-60433
Choose a base branch
from

Conversation

KiMauVA
Copy link
Contributor

@KiMauVA KiMauVA commented Nov 14, 2024

Resolves APPEALS-42573 Correspondence and Appeal Tasks: Inbound Ops Team Superuser/visor: Add tasks to linked appeals: Add task modal

Description

This adds the functionality to add tasks to linked appeals on the Correspondence Details page.

Acceptance Criteria

  • Code compiles correctly

Testing Plan

  1. Log in as a Superuser/Supervisor.
  2. Build (from Existing Appeals) or Intake (from Intake workflow) a Correspondence with linked appeals.
  3. If there are less than 4 tasks on the appeal, a button that says "+ Add Task" should populate.
  4. On clicking it, a Modal should pop up
  5. Fill in the Task and Instructions
  6. "Submit" -- The AC calls out that it should say "Next" to prepare for the AutoText portion, but it just submits with that next button right now.
  7. Task should populate on the Correspondence Details page with success banner.

Notes:

  1. Unsaved, temporary linked appeals do not have this functionality.
  2. Non-super users should be able to see the tasks, but not add them with the button.
  3. The front-end takes a moment to catch up with the updates, but it should only be a second or two seconds.
  4. The modal has submission safeties in place, and requires both the task to be selected, and the text box filled out.

Best practices

Code Documentation Updates

  • Add or update code comments at the top of the class, module, and/or component.

Tests

Test Coverage

Did you include any test coverage for your code? Check below:

  • RSpec

Code Climate

Your code does not add any new code climate offenses? If so why?

  • No new code climate issues added

@KiMauVA KiMauVA changed the base branch from main to feature/APPEALS-60433 November 14, 2024 20:16
Copy link

codeclimate bot commented Nov 14, 2024

Code Climate has analyzed commit 3f2725f and detected 8 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 5
Duplication 2
Style 1

View more on Code Climate.

@@ -32,10 +33,23 @@ export const setWaiveEvidenceAlertBanner = (bannerDetails) => (dispatch) => {
});
};

export const setTaskRelatedToAppealBanner = (bannerDetails) => (dispatch) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could be wrong, but is this being used? I see where it's imported but I don't see where it's explicitly called.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants