Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APPEALS-61670: Update job to call 'distribute non genpop priority appeals' every time #23525

Open
wants to merge 9 commits into
base: feature/APPEALS-61385
Choose a base branch
from

Conversation

craigrva
Copy link
Contributor

@craigrva craigrva commented Nov 15, 2024

Resolves APPEALS-61670

Description

Updates the PushPriorityAppealsToJudgesJob to specifically distribute non-genpop priority appeals before beginning the process of calculating and distributing the genpop priority appeals.

  • Modifies the PushPriorityAppealsToJudgesJob to not skip the distribute_non_genpop_priority_appeals method call
    • Adds a feature toggle :acd_ppj_distribute_not_genpop to allow us to disable this if there is a problem in the future
  • Fixes a bug in the CaseDocket common filter logic where if a legacy appeal with no hearing was held had a deciding judge on the Ineligible Judges list, it would distribute when genpop was set to not_genpop for that distribution, even though it is a genpop appeal
    • Adds two appeals to the case_docket and aoj_case_docket test files for the above scenario
  • Fixes the batch_size value for previous distributions in the seed data
  • Updates and adds tests to push_priority_appeals_to_judges_job_spec.rb for distributing non-genpop appeals with the new feature toggle enabled

Acceptance Criteria

  • Code compiles correctly
  • Distribution Rspec tests are passing
  • PushPriorityAppealsToJudgesJob distributes all non-genpop ready priority appeals to eligible judges before calculating or distributing any genpop priority appeals

Testing Plan

  1. make reset or re-seed a demo environment with the "reseed DB" button
  2. Run the PushPriorityAppealsToJudgesJob, either via the scheduled jobs page in the UI or via the rails console
  3. Verify that appeals were distributed to their tied/affinity judge, if applicable
  4. Verify that the number of distributed appeals is relatively even
  5. Verify that if a judge received tied/affinity appeals, that they received fewer genpop appeals than a judge who did not receive any tied/affinity appeals

@craigrva craigrva marked this pull request as ready for review November 15, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants