Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-14541: Add Reusable QAs component for R&S detail pages #1656

Merged
merged 2 commits into from
Aug 14, 2023

Conversation

chriskim2311
Copy link
Contributor

@chriskim2311 chriskim2311 commented Aug 9, 2023

Description

We want to create a reusable QA component that can be utilized across different benefits details pages.

relates to department-of-veterans-affairs/va.gov-cms#14541

Testing done & Screenshots

Testing with different scenarios of QA group implementation.
Tugboat instance to verify: https://web-puvomwkxsno6aa4slenuvyqhhoin1hox.ci.cms.va.gov/resources/test-test-1/

Placing QA Group in an ordered list:
order1

QA Group alone:
qa_alone

QA Group at the end of the list:
Test_QA_Group_At_The_End___Veterans_Affairs

QA steps

What needs to be checked to prove this works?
Verify that the QA group is valid in ordered list
What needs to be checked to prove it didn't break any related things?
Check against R&S pages that have QA Groups embedded in details pages.

Definition of done

  • Events are logged appropriately
  • Documentation has been updated, if applicable
  • A link has been provided to the originating GitHub issue (or connected to it via ZenHub)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs

Copy link
Contributor

@randimays randimays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@rmessina1010 rmessina1010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chriskim2311 chriskim2311 merged commit 48f4677 into main Aug 14, 2023
23 checks passed
@chriskim2311 chriskim2311 deleted the VACMS-14541-reusable-qas branch August 14, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants