VACMS 18910 - Michelle M/Product is moving commonly treated conditions to CSV value

[eselkin]

Summary

• Michelle M and Michael S discussed moving the commonly treated conditions to (when present) CSV in place of "and" terminated list
• Sitewide

Related issue(s)

• [AutoSuggest for "Service type"] Step 2 - Ability to search within JSONified data va.gov-cms#18910

Testing done

• Manually tested from CMS

Screenshots

N/A

What areas of the site does it impact?

JSON creation postprocessing of Drupal loaded data

Acceptance criteria

• See vets-website PR useServiceTypeFilter hook for typeahead - with facility type optional vets-website#32930

Quality Assurance & Testing

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Linting warnings have been addressed
• Documentation has been updated (link to documentation *if necessary)
• Screenshot of the developed feature is added
• Accessibility testing has been performed

Error Handling

• Browser console contains no warnings or errors.
• Events are being sent to the appropriate logging solution
• Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

• Did you login to a local build and verify all authenticated routes work as expected with a test user

Requested Feedback

Check that .cache/localhost/drupal/static-data-files/va-healthcare-services.json is created with a second value per array that is now an array of strings.

[randimays]

I wasn't quite sure what this meant:

Check that .cache/localhost/drupal/static-data-files/va-healthcare-services.json is created with a second value per array that is now an array of strings.

The file I generated locally seems to be a giant array of arrays - is this the expected result?

[eselkin]

Yep. It just adds one more element that's an array. Mooore arrays. The 3rd element of each nested array used to be a string now it's an array of strings.

[randimays]

Gotcha, thanks! Approved.