VACMS-19516 Adjust email container structure and spacing #2348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randimays
commented
Nov 7, 2024
| @@ -1,47 +1,47 @@ | |||
| <div class="homepage-email-update-wrapper vads-u-background-color--primary-alt-lightest vads-u-padding-x--2p5 vads-u-padding-top--2p5"> | |||
| {% assign shouldShowExistingEmailForm = '' | showExistingEmailForm %} | |||
There was a problem hiding this comment.
This assign / if moved from lines 4-6 to lines 2-4. Then the else and endif moved from lines 40-42 to lines 42-44. The rest of the code is unchanged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adjust the container structure of the email signup widget. The current version has a lot of nested
divs that make it difficult to properly center the form with the proper length of the text input intact. The current/original version is unchanged, I simply isolated those extradivs to that version and simplified the implementation of the new React widget so I could style it properly.Related issue(s)
Testing done
Since the React widget code has not been merged yet, it is more important to validate this style/structure change against the existing email form. But I did add screenshots of the React widget form because I have a branch of that code locally.
Screenshots
Current version (unchanged)
React widget
What areas of the site does it impact?
Homepage email signup widget only.