Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VEBT-729 Removing 22-0993 #2352

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

VEBT-729 Removing 22-0993 #2352

wants to merge 15 commits into from

Conversation

GovCIOLiz
Copy link
Contributor

@GovCIOLiz GovCIOLiz commented Nov 12, 2024

Summary

Removing 0993 react app form

Related issue(s)

VEBT-729
department-of-veterans-affairs/vets-website#32981 has been merged first per 'deleting a folder' instructions

Testing done

  • Describe what the old behavior was prior to the change
  • Describe the steps required to verify your changes are working as expected
  • Describe the tests completed and the results
  • _Exclusively stating 'Specs and automated tests passing' is NOT acceptable as appropriate testing
  • Optionally, provide a link to your test plan and test execution records

Screenshots

Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).

Before After
Mobile
Desktop

What areas of the site does it impact?

(Describe what parts of the site are impacted if code touched other areas)

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

GovCIOLiz and others added 15 commits August 20, 2024 17:31
* Fix to breadcrumb padding on certain drupal pages.

* Adding row back

* Removing another un-needed class

* Adding padding to containing div
* update web-components

Signed-off-by: Micah Chiang <[email protected]>

* bump version

Signed-off-by: Micah Chiang <[email protected]>

---------

Signed-off-by: Micah Chiang <[email protected]>
* added feedback button to checklist drupal template

* moved element to under back-to-top element
* creates va-healthcare-services.json
* remove spaces from JSONs
* process the processed HTML to text
* simplify
Signed-off-by: Micah Chiang <[email protected]>
* Update SCO registry.json route

* Update registry.json for sco url

* Making separate PR

* Fix to breadcrumb padding on certain drupal pages. (#2241)

* Fix to breadcrumb padding on certain drupal pages.

* Adding row back

* Removing another un-needed class

* Adding padding to containing div

* Turn on production flag for rollout (#2246)

* update web-components (#2249)

* update web-components

Signed-off-by: Micah Chiang <[email protected]>

* bump version

Signed-off-by: Micah Chiang <[email protected]>

---------

Signed-off-by: Micah Chiang <[email protected]>

* Medallia - Add feedback button to checklist page layout (#2247)

* added feedback button to checklist drupal template

* moved element to under back-to-top element

* VACMS 18909 KISS autosuggest data for services from taxonomies (#2248)

* creates va-healthcare-services.json
* remove spaces from JSONs
* process the processed HTML to text
* simplify

* bump web components (#2250)

Signed-off-by: Micah Chiang <[email protected]>

---------

Signed-off-by: Micah Chiang <[email protected]>
Co-authored-by: Andrew Steele <[email protected]>
Co-authored-by: Kevin Duensing <[email protected]>
Co-authored-by: Micah Chiang <[email protected]>
Co-authored-by: Aubrey Arcangel <[email protected]>
Co-authored-by: Eli Selkin <[email protected]>
Copy link
Contributor

@harshil1793 harshil1793 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants