-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VEBT-729 Removing 22-0993 #2352
Open
GovCIOLiz
wants to merge
15
commits into
main
Choose a base branch
from
vebt-729
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix to breadcrumb padding on certain drupal pages. * Adding row back * Removing another un-needed class * Adding padding to containing div
* update web-components Signed-off-by: Micah Chiang <[email protected]> * bump version Signed-off-by: Micah Chiang <[email protected]> --------- Signed-off-by: Micah Chiang <[email protected]>
* added feedback button to checklist drupal template * moved element to under back-to-top element
* creates va-healthcare-services.json * remove spaces from JSONs * process the processed HTML to text * simplify
Signed-off-by: Micah Chiang <[email protected]>
* Update SCO registry.json route * Update registry.json for sco url * Making separate PR * Fix to breadcrumb padding on certain drupal pages. (#2241) * Fix to breadcrumb padding on certain drupal pages. * Adding row back * Removing another un-needed class * Adding padding to containing div * Turn on production flag for rollout (#2246) * update web-components (#2249) * update web-components Signed-off-by: Micah Chiang <[email protected]> * bump version Signed-off-by: Micah Chiang <[email protected]> --------- Signed-off-by: Micah Chiang <[email protected]> * Medallia - Add feedback button to checklist page layout (#2247) * added feedback button to checklist drupal template * moved element to under back-to-top element * VACMS 18909 KISS autosuggest data for services from taxonomies (#2248) * creates va-healthcare-services.json * remove spaces from JSONs * process the processed HTML to text * simplify * bump web components (#2250) Signed-off-by: Micah Chiang <[email protected]> --------- Signed-off-by: Micah Chiang <[email protected]> Co-authored-by: Andrew Steele <[email protected]> Co-authored-by: Kevin Duensing <[email protected]> Co-authored-by: Micah Chiang <[email protected]> Co-authored-by: Aubrey Arcangel <[email protected]> Co-authored-by: Eli Selkin <[email protected]>
12 tasks
GcioNapoleon
approved these changes
Nov 12, 2024
14 tasks
harshil1793
reviewed
Nov 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
harshil1793
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removing 0993 react app form
Related issue(s)
VEBT-729
department-of-veterans-affairs/vets-website#32981 has been merged first per 'deleting a folder' instructions
Testing done
Screenshots
Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).
What areas of the site does it impact?
(Describe what parts of the site are impacted if code touched other areas)
Acceptance criteria
Quality Assurance & Testing
Error Handling
Authentication
Requested Feedback
(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?