Merge branch 'main' into loan-review-release-notes

.github/workflows/send-to-lpb.yaml

@@ -13,6 +13,7 @@ jobs:
     name: Gather the changed content
     runs-on: ubuntu-latest
     outputs:
+      rename_warning: ${{ steps.get_target_environment.outputs.rename_warning }}
       target_environment: ${{ steps.get_target_environment.outputs.target_environment }}
     steps:
       - id: get_target_environment
@@ -23,24 +24,27 @@ jobs:
             TARGET_ENVIRONMENT="production"
           fi
           echo $TARGET_ENVIRONMENT
-          echo "::set-output name=target_environment::$TARGET_ENVIRONMENT"
+          echo "target_environment=$TARGET_ENVIRONMENT" >> $GITHUB_OUTPUT
       - name: Checkout
         uses: actions/checkout@v2
         with:
           fetch-depth: 0
       - id: pr_files
-        uses: Ana06/get-changed-files@v1.2
+        uses: Ana06/get-changed-files@v2.2.0
       - id: upload_content
         name: Find files and send them
         continue-on-error: true
         run: |
           # If it's a PR change from a space delimited list to one file per line
-          if [ "${{ steps.pr_files.outputs.added_modified }}" != "" ]; then
+          if [ "${{ steps.pr_files.outputs.added_modified_renamed }}" != "" ]; then
             touch changed-files.txt
-            for f in `echo "${{ steps.pr_files.outputs.added_modified }}"`; do
+            for f in `echo "${{ steps.pr_files.outputs.added_modified_renamed }}"`; do
               echo $f >> changed-files.txt
             done
           fi
+          if [ "${{ steps.pr_files.outputs.renamed }}" != "" ]; then
+            echo "rename_warning=TRUE" >> $GITHUB_OUTPUT
+          fi
           echo "Expected files changes:"
           cat changed-files.txt
       - name: Save changed files list
@@ -108,6 +112,17 @@ jobs:
               repo: context.repo.repo,
               body: 'These changes have been pushed to [dev](https://dev-developer.va.gov/release-notes/).'
             })
+      - name: Previously Merged Warning Comment on PR
+        if: needs.gather_content.outputs.rename_warning == 'TRUE'
+        uses: actions/github-script@v6
+        with:
+          script: |
+            github.rest.issues.createComment({
+              issue_number: context.issue.number,
+              owner: context.repo.owner,
+              repo: context.repo.repo,
+              body: 'If this release note was merged to the `main` branch on another PR, you will need to reach out to [Team Okapi](https://lighthouseva.slack.com/archives/C01931CFMTQ) to remove the copy that remains on the previous date.'
+            })
   send_content_to_production:
     name: Send content to production LPB
     needs: [gather_content]

.gitignore

@@ -2,3 +2,4 @@ changed-files.txt
 .DS_Store
 node_modules
 bearer.token
+.idea

content/direct-deposit-management/release-notes/2022-12-15.md

@@ -0,0 +1,28 @@
+We added a new API to the developer portal called the **[Direct Deposit Management API](https://developer.va.gov/explore/benefits/docs/direct-deposit-management?version=current)**.
+
+This API replaces the EVSS Patient Payment Information Update (PPIU) service and offers many added benefits, such as:
+
+  - Detailed error response bodies with helpful troubleshooting information for existing and new error response codes.
+  - Removed routing number checks against an outdated list of fraudulent routing numbers (and all associated errors).
+  - More data being cached for latency improvement purposes.
+
+**Important Differences between the Direct Deposit Management API and the Legacy Service:**
+- The API is now on `developer.va.gov`. Therefore, the URLs have changed:
+  * Legacy URL: `https://www.ebenefits.va.gov:444/<servicename>/<endpointname>`
+  * New URL:    `https://api.va.gov/services/<servicename>/v1/<endpointname>`
+- The new API requires OAuth, so consumers will not need to pass PII. Instead, consumers will provide the ICN in each request using a query parameter. The API will pull additional Veteran details as needed.
+- Responses are in JSON instead of HTML. 
+- Error messages are no longer part of the common response for both endpoints. They are handled in 400, 422, or 500 responses.
+
+As always, it is important to support backward compatibility.
+
+Your integration should:
+- Be prepared to handle HTTP status codes not explicitly specified in endpoint definitions.
+- Be tolerant of unknown fields in the payload and ignore the deserialization of new fields.
+- Follow the redirect when the server returns an HTTP status code 301 (Moved Permanently).
+
+Learn more about this API by reviewing the [Direct Deposit Management API documentation](https://developer.va.gov/explore/benefits/docs/direct-deposit-management?version=current).
+
+For cross-reference purposes, the PR for this release is [#15](https://github.com/department-of-veterans-affairs/lighthouse-direct-deposit-management-deployment/pull/15).
+
+The deployed release version is [1.0.39](https://github.com/department-of-veterans-affairs/lighthouse-direct-deposit-management-deployment/releases/tag/1.0.39).

content/verification/va-letter-generator/release-notes/2022-09-02.md → content/verification/va-letter-generator/release-notes/2022-12-14.md

@@ -1,22 +1,14 @@
-VA Letter Generator API
-
-Month dd, 2022
-
-We added the new GET letter-contents/{letterType} endpoint to the VA Letter Generator API.<br> 
-This endpoint returns JSON-formatted text versions of letters a specified Veteran is eligible to receive.<br>
+We added the new GET letter-contents/{letterType} endpoint to the VA Letter Generator API.  
+This endpoint returns JSON-formatted text versions of letters a specified Veteran is eligible to receive.  
 The JSON-formatted letter content can be used to deliver letters in formats other than PDF.
 
 Learn more about this API by reviewing the [VA Letter Generator documentation](https://community.max.gov/display/VAExternal/VA+Letter+Generator+API).
 
-The PR for this release is #TBD.
-
-_____________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________
-
+The version number for this release is 1.0.126
 
-Month dd, 2022
+---
 
-We added a new API to the developer portal called the **[VA Letter Generator API](https://community.max.gov/display/VAExternal/VA+Letter+Generator+API)**.
-<br>
+We added a new API to the developer portal called the **[VA Letter Generator API](https://community.max.gov/display/VAExternal/VA+Letter+Generator+API)**.  
 This API replaces the EVSS Letter Generator Service and offers many added benefits, including:
 
 - Detailed error response bodies for error response codes
@@ -76,8 +68,8 @@ This API replaces the EVSS Letter Generator Service and offers many added benefi
   * benefitInformation.chapter35EligibilityDate is now benefitInformation.chapter35EligibilityDateTime
 
 
-As always, it's important to know that with the new version, you will need to support backward compatibility.<br>
-You should:
+As always, it's important to know that with the new version, you will need to support backward compatibility.  
+You should:  
 - Keep in mind that we may add new letters to this API. 
 - We recommend you build your integration, so it can display newly added letters without breaking. 
 - You could also build your integration to ignore newly added letters until it’s ready to display them.
@@ -86,4 +78,4 @@ You should:
 - Follow the redirect when the server returns an HTTP status code 301 (Moved Permanently).
 
 
-The PR for this release is #TBD.
+The version number for this release is 1.0.126