[FEATURE] Users public bio feature #1108
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camillevilla
changed the title
* create migration to add fellow-related columns to users table * update schema with added fellow-related columns on users table * add :fellowship col addition to users table update migration * update schema with added :fellowships column on users table * update UsersController to allow fellow-related params * update user edit profile form adds public-bio related fields * add feature specs for public-bio related fields in user profile edit form * update users col additions migrations to remove :fellowship col * update schema to remove :fellowship col from users table * update users profile form to remove :fellowship field * Update app/controllers/users_controller.rb --------- Co-authored-by: Camille Villa <[email protected]>
* add file for user profile js contains logic for uploading user profile photos * update .avatar-profile-photo css class * update user profile partial adjusts logic to enable photo upload and removal for users with granted_public_bio: true elements dealing with photo editing commented out, leaving behind in case the functionality ever needs to be re-implemented * update user_profile_utilities js cleans up functions by removing unused vars * add feature test for user profile pic management
PhilipDeFraties
force-pushed
the
user-public-bio-feature-branch
branch
from
5043394
to
bbd61d4
Compare
* add :accolades col to users table * add field for :accolades input to user profile edit form * add test for user accolades management to user profile feature spec
* add #to_param method to User model to customize url path to include user's preferred name * add link to user bio page from edit profile page * update user feature specs to use fake demographic data * add button that links bio page to profile edit page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA issue link
Description - what does this code do?
Testing done - how did you test it/steps on how can another person can test it
Screenshots, Gifs, Videos from application (if applicable)
Link to mock-ups/mock ups (image file if you have it) (if applicable)
Acceptance criteria
Definition of done