Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dm-5157 public user bio page #1117

Merged

Conversation

PhilipDeFraties
Copy link
Collaborator

@PhilipDeFraties PhilipDeFraties commented Nov 13, 2024

JIRA issue link

https://agile6.atlassian.net/browse/DM-5092

Description - what does this code do?

Adds endpoint and page for public user bio

Testing done - how did you test it/steps on how can another person can test it

  1. Update a user to granted_public_bio: true
  2. Sign in as that user, go to the /edit_profile page and fill out the public bio fields
  3. Go to /bios/{user.id}-{user.alt_first_name}-{user.alt_last_name} (really anything after the id works as it is removed from the params in the controller action, this will allow links to show the fellows' names without needing to account for duplicate names or lack of presence of alt names)
  4. Verify the user's public bio information and avatar render on the page renders as expected (placeholder image if no avatar), compare with the mockup
    Note: the name at the top of the page will utilize the alt names if available but default to the normal name values if not

Screenshots, Gifs, Videos from application (if applicable)

Screenshot 2024-11-13 at 2 28 13 PM

Link to mock-ups/mock ups (image file if you have it) (if applicable)

Acceptance criteria

  • [ ]

Definition of done

  • Unit tests written (if applicable)
  • e2e/accessibility tests written (if applicable)
  • Events are logged appropriately
  • Documentation has been updated, if applicable
  • A link has been provided to the originating JIRA issue
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs

@PhilipDeFraties PhilipDeFraties changed the base branch from master to user-public-bio-feature-branch November 13, 2024 21:09
@PhilipDeFraties PhilipDeFraties self-assigned this Nov 13, 2024
@PhilipDeFraties PhilipDeFraties merged commit 26190a7 into user-public-bio-feature-branch Nov 14, 2024
@PhilipDeFraties PhilipDeFraties deleted the dm-5092-public-bio-page branch November 14, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants