Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update users migration to make :work col json #1125

Open
wants to merge 12 commits into
base: user-public-bio-feature-branch
Choose a base branch
from

Conversation

PhilipDeFraties
Copy link
Collaborator

JIRA issue link

https://agile6.atlassian.net/browse/DM-5338

Description - what does this code do?

Adds logic and updates views to allow for management and display of users' work entries as hyperlinks

Testing done - how did you test it/steps on how can another person can test it

  1. update a user to granted_public_bio: true, nav to /edit-profile
  2. add text and valid url to the empty fields in the "Work" section, verify they persist upon form submission
  3. verify you can add another by clicking the "Add Another Work Link" button, wherein a blank set of fields appear and the "Add Another Work Link" button moves to be below the empty fields.
  4. Verify that added links persist, and that links removed with the "Remove" button persist as being removed.
  5. Verify that when you remove all links a blank set of fields appears and that the data persists as expected when the form is submitted.
  6. Verify that a link formatted as "www.google.com" or "google.com" persists, but that anything missing a TLD results in a form error and prevents submission. Links saved without a "http" protocol should automatically save with "https" protocol inserted in the link text.
  7. Verify that persisted links render as hyperlinks on the bio page (`/bios/{user.id}"), links saved with no text will just list the link itself.

Screenshots, Gifs, Videos from application (if applicable)

Screenshot 2024-11-14 at 5 22 24 PM Screenshot 2024-11-14 at 5 22 36 PM Screenshot 2024-11-14 at 5 23 08 PM

Link to mock-ups/mock ups (image file if you have it) (if applicable)

Acceptance criteria

  • [ ]

Definition of done

  • Unit tests written (if applicable)
  • e2e/accessibility tests written (if applicable)
  • Events are logged appropriately
  • Documentation has been updated, if applicable
  • A link has been provided to the originating JIRA issue
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant