CU: Remove hideArrow code from AccordionCollapsible (#9802)

Co-authored-by: Therese <[email protected]>
department-of-veterans-affairs · Oct 15, 2024 · 8dddb9a · 8dddb9a
1 parent 189a894
commit 8dddb9a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 24 deletions.
diff --git a/VAMobile/src/components/AccordionCollapsible.test.tsx b/VAMobile/src/components/AccordionCollapsible.test.tsx
@@ -9,11 +9,10 @@ import Mock = jest.Mock
 
 context('AccordionCollapsible', () => {
   let onPressSpy: Mock
-  const initializeTestInstance = (hideArrow = false, expandedInitialValue = false) => {
+  const initializeTestInstance = (expandedInitialValue = false) => {
     onPressSpy = jest.fn(() => {})
     render(
       <AccordionCollapsible
-        hideArrow={hideArrow}
         header={<TextView>HEADER</TextView>}
         expandedContent={<TextView>EXPANDED</TextView>}
         collapsedContent={<TextView>COLLAPSED</TextView>}
@@ -43,13 +42,8 @@ context('AccordionCollapsible', () => {
       expect(onPressSpy).toBeCalled()
     })
 
-    it('when hideArrow set to true, cannot find tab to press', () => {
+    it('when expandedInitialValue is true it should show Expanded and not Collapsed content on load', () => {
       initializeTestInstance(true)
-      expect(screen.queryByRole('tab')).toBeFalsy()
-    })
-
-    it('when expandedIntiailValue is true it should show Expanded and not Collapsed content on load', () => {
-      initializeTestInstance(false, true)
       expect(screen.getByRole('tab', { name: 'HEADER' })).toBeTruthy()
       expect(screen.queryByText('COLLAPSED')).toBeFalsy()
       expect(screen.getByText('EXPANDED')).toBeTruthy()

diff --git a/VAMobile/src/components/AccordionCollapsible.tsx b/VAMobile/src/components/AccordionCollapsible.tsx
@@ -22,8 +22,6 @@ export type AccordionCollapsibleProps = {
   a11yHint?: string
   /** component to display on when the accordion is collapsed */
   collapsedContent?: ReactNode
-  /** if true hides the accordion arrow and only displays header & collapsed content */
-  hideArrow?: boolean
   /** custom on press call if more action is needed when expanding/collapsing the accordion */
   customOnPress?: (expandedValue?: boolean) => void
   /** sets the initial value of expanded if an accordion should already be expanded on render */
@@ -41,7 +39,6 @@ const AccordionCollapsible: FC<AccordionCollapsibleProps> = ({
   header,
   expandedContent,
   collapsedContent,
-  hideArrow,
   testID,
   customOnPress,
   expandedInitialValue,
@@ -78,11 +75,9 @@ const AccordionCollapsible: FC<AccordionCollapsibleProps> = ({
     const data = (
       <Box flexDirection="row">
         <Box flex={1}>{header}</Box>
-        {!hideArrow && (
-          <Box alignItems="flex-end">
-            <Icon name={iconName} fill={theme.colors.icon.chevronCollapsible} width={30} height={30} />
-          </Box>
-        )}
+        <Box alignItems="flex-end">
+          <Icon name={iconName} fill={theme.colors.icon.chevronCollapsible} width={30} height={30} />
+        </Box>
       </Box>
     )
 
@@ -92,14 +87,6 @@ const AccordionCollapsible: FC<AccordionCollapsibleProps> = ({
         }
       : {}
 
-    if (hideArrow) {
-      return (
-        <Box {...labelProps} accessible={true}>
-          {data}
-        </Box>
-      )
-    }
-
     return (
       <Pressable {...pressableProps} {...labelProps} ref={headerRef}>
         {data}