Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(GHA) Verify builds work in PRs with relevant changes #8267

Open
2 tasks
theodur opened this issue Mar 28, 2024 · 2 comments · May be fixed by #10202
Open
2 tasks

(GHA) Verify builds work in PRs with relevant changes #8267

theodur opened this issue Mar 28, 2024 · 2 comments · May be fixed by #10202
Assignees
Labels
devops QA and Release Label identifies this work is done on the QA and Release Team

Comments

@theodur
Copy link
Contributor

theodur commented Mar 28, 2024

Description

There are instances where we may want to confirm that changes in a PR didn't break the app build. This would serve as a gate to prevent changes that don't require manual QA from being merged into develop without confirming the build still works. This is mainly a concern when updating the folders for native code, e.g. VAMobile/android, VAMobile/ios.

Acceptance criteria

  • Determine which scenarios a build should run in CI for verification
  • Update the CI workflow to run a test build when those scenarios occur in PRs
@theodur theodur added devops front-end Ticket requires front-end work global Issues for the global team labels Mar 28, 2024
@theodur theodur self-assigned this Mar 28, 2024
@timwright12 timwright12 added QA and Release Label identifies this work is done on the QA and Release Team and removed front-end Ticket requires front-end work global Issues for the global team labels Jul 23, 2024
@timwright12
Copy link
Contributor

Kicking this over the the release team (cc: @bischoffa )

@bischoffa
Copy link
Contributor

Added this to DevOps Q3 epic for consideration. Will need to be reviewed and sized before being worked so moving the ticket to New Issues column

@lexicalninja lexicalninja self-assigned this Nov 15, 2024
@lexicalninja lexicalninja linked a pull request Nov 15, 2024 that will close this issue
6 tasks
@lexicalninja lexicalninja linked a pull request Nov 15, 2024 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops QA and Release Label identifies this work is done on the QA and Release Team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants