Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT - Verify builds work before PRs are merged #10202

Draft
wants to merge 18 commits into
base: develop
Choose a base branch
from

Conversation

lexicalninja
Copy link
Contributor

@lexicalninja lexicalninja commented Nov 15, 2024

Description of Change

creates processes for #8267

There are a few things here, we may consider breaking into 2 or 3 different PRs for atomic purposes:

  1. adds ios and android bundle to the code_checks.yml file. This allows us to make sure any changes to the app arent breaking the js bundling process.

  2. adds a set of build check work for android and ios when we change any files in their native directories. Each one has a new lane added to the fastfile, and three new yml files to make sure each check only counts once. see this for an explanation

Testing

workflows all pass and only one version runs for each platform.

Reviewer Validations

code quality, readability, etc
Should this be multiple PRs?

Once this is merged, we will need to test that a PR that does not include files from these directories fires the skip script and does not fire a duplicate action. if that works, these can be made required checks.

PR Checklist

Reviewer: Confirm the items below as you review

  • PR is connected to issue(s)
  • Tests are included to cover this change (when possible)
  • No magic strings (All string unions follow the Union -> Constant type pattern)
  • No secrets or API keys are checked in
  • All imports are absolute (no relative imports)
  • New functions and Redux work have proper TSDoc annotations

For QA

Run a build for this branch

@lexicalninja lexicalninja linked an issue Nov 15, 2024 that may be closed by this pull request
2 tasks
@lexicalninja lexicalninja changed the title add bundle check for PRs DRAFT - Verify builds work before PRs are merged Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(GHA) Verify builds work in PRs with relevant changes
1 participant