-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DRAFT - Verify builds work before PRs are merged #10202
Draft
lexicalninja
wants to merge
18
commits into
develop
Choose a base branch
from
8267-gha-verify-builds-work-in-prs-with-relevant-changes
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
DRAFT - Verify builds work before PRs are merged #10202
lexicalninja
wants to merge
18
commits into
develop
from
8267-gha-verify-builds-work-in-prs-with-relevant-changes
+120
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
lexicalninja
changed the title
add bundle check for PRs
DRAFT - Verify builds work before PRs are merged
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
creates processes for #8267
There are a few things here, we may consider breaking into 2 or 3 different PRs for atomic purposes:
adds ios and android bundle to the
code_checks.yml
file. This allows us to make sure any changes to the app arent breaking the js bundling process.adds a set of build check work for android and ios when we change any files in their native directories. Each one has a new lane added to the fastfile, and three new yml files to make sure each check only counts once. see this for an explanation
Testing
workflows all pass and only one version runs for each platform.
Reviewer Validations
code quality, readability, etc
Should this be multiple PRs?
Once this is merged, we will need to test that a PR that does not include files from these directories fires the skip script and does not fire a duplicate action. if that works, these can be made required checks.
PR Checklist
Reviewer: Confirm the items below as you review
For QA
Run a build for this branch