Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CU/9768-Chika-Rollback-2779-and-test-RQ #10038

Merged
merged 8 commits into from
Oct 29, 2024
Merged

CU/9768-Chika-Rollback-2779-and-test-RQ #10038

merged 8 commits into from
Oct 29, 2024

Conversation

cadibemma
Copy link
Contributor

Description of Change

  • 2779 was developed to ensure our api responses weren't stepping on top of each other in our old redux environment. We'd like to confirm whether or not this is still necessary in a React Query environment. This takeaway will drive how we have to use AbortController app-wide.

Screenshots/Video

Testing

  • Tested on iOS
  • Tested on Android

Reviewer Validations

PR Checklist

Reviewer: Confirm the items below as you review

  • PR is connected to issue(s)
  • Tests are included to cover this change (when possible)
  • No magic strings (All string unions follow the Union -> Constant type pattern)
  • No secrets or API keys are checked in
  • All imports are absolute (no relative imports)
  • New functions and Redux work have proper TSDoc annotations

For QA

Run a build for this branch

@cadibemma cadibemma marked this pull request as ready for review October 25, 2024 20:03
@cadibemma cadibemma requested review from a team as code owners October 25, 2024 20:03
rbontrager
rbontrager previously approved these changes Oct 28, 2024
View reviewed changes
@github-actions github-actions bot added the FE-With QA A PR waiting for QA Activity label Oct 29, 2024
@github-actions github-actions bot added FE-Ready to Merge and removed FE-With QA A PR waiting for QA Activity labels Oct 29, 2024
@cadibemma cadibemma merged commit 57dc803 into develop Oct 29, 2024
41 of 42 checks passed
@cadibemma cadibemma deleted the 9768-pt2-rollback-2779-and-test-RQ branch October 29, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dumathane dumathane dumathane approved these changes

@rbontrager rbontrager rbontrager approved these changes

@timwright12 timwright12 Awaiting requested review from timwright12 timwright12 is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@alexandec alexandec Awaiting requested review from alexandec alexandec is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@theodur theodur Awaiting requested review from theodur theodur is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@Sparowhawk Sparowhawk Awaiting requested review from Sparowhawk Sparowhawk is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@DonMcCaugheyUSDS DonMcCaugheyUSDS Awaiting requested review from DonMcCaugheyUSDS DonMcCaugheyUSDS is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

Assignees
No one assigned
Labels
FE-Ready to Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cadibemma @rbontrager @dumathane