Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automation/6808-chanel-create-system-for-updating-names-on-release-tickets #10044

Merged

Conversation

IsraelleHub
Copy link
Contributor

@IsraelleHub IsraelleHub commented Oct 25, 2024

Description of Change

Updating names on the the release ticket is a manual process right now

Investigate if we can auto-assign people to the release ticket based on the folks listed in a github group. We should be able to read the people in a certain group, then assign them to the release ticket instead of having to maintain a manual list inside the workflow like we currently do.

release issue example
release issue creation workflow

Screenshots/Video

Testing

Test was done by cloning the release_issue.md file and using a test workflow.
Example of release ticket that the test workflow created and auto-assigned members of the flagship-mobile-release-approvers using gh cli.
In addition, workflow update the assignee of release_ticket md file automatically whenever there is any change on the https://github.com/orgs/department-of-veterans-affairs/teams/flagship-mobile-release-approvers/members goup

  • Tested on iOS
  • Tested on Android

Reviewer Validations

PR Checklist

Reviewer: Confirm the items below as you review

  • PR is connected to issue(s)
  • Tests are included to cover this change (when possible)
  • No magic strings (All string unions follow the Union -> Constant type pattern)
  • No secrets or API keys are checked in
  • All imports are absolute (no relative imports)
  • New functions and Redux work have proper TSDoc annotations

For QA

Run a build for this branch

@IsraelleHub IsraelleHub self-assigned this Oct 25, 2024
@IsraelleHub IsraelleHub marked this pull request as draft November 7, 2024 23:26
@IsraelleHub IsraelleHub marked this pull request as ready for review November 12, 2024 20:40
@timwright12 timwright12 self-requested a review November 13, 2024 13:43
narin
narin previously approved these changes Nov 13, 2024
Copy link
Contributor

@narin narin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Some minor nitpicks but should be good to go otherwise.

- name: Assign Users to Release Ticket
if: ${{ success() }}
run: |
#Fetch GitHub Group Members
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add space after # if keeping this comment

Comment on lines 54 to 55
# Debug output just for testing
echo "Formatted Assignees: $ASSIGNEES"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove these lines if they are for testing only

@github-actions github-actions bot added the FE-With QA A PR waiting for QA Activity label Nov 13, 2024
@narin narin merged commit b523b24 into develop Nov 13, 2024
14 of 16 checks passed
@narin narin deleted the chanel-6808-create-system-for-updating-names-on-release-tickets branch November 13, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops FE-With QA A PR waiting for QA Activity QA and Release Label identifies this work is done on the QA and Release Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants