-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug/9925-Android15Biometrics #10061
Merged
Merged
bug/9925-Android15Biometrics #10061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theodur
requested review from
timwright12,
alexandec,
dumathane,
cadibemma,
Sparowhawk and
DonMcCaugheyUSDS
November 7, 2024 17:35
dumathane
approved these changes
Nov 12, 2024
TKDickson
approved these changes
Nov 13, 2024
github-actions
bot
added
FE-Ready to Merge
and removed
FE-With QA
A PR waiting for QA Activity
labels
Nov 13, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixes biometrics not working on Android 15 devices. The root issue seems to be with the
react-native-keychain
library, so an actual fix will need to come from the library. After upgrading to the latest version ofreact-native-keychain
, it seems like biometrics works intermittently on Android 15 devices. What this PR does is add retry functionality for retrieving the refresh token from biometrics. This allows 3 attempts at retrieving the refresh token, which from what I've seen should be enough for successful retrieval on Android 15.During the biometric retries, users would be stuck on the login screen without any indication of what's happening, so I added functionality to display a loading icon on the login screen whenever the refresh token if being retrieved from biometrics. This way, it won't seem like there is a long delay before the sign in process is actually continued.
Screenshots/Video
Before
screen-20241107-021715.mp4
After
screen-20241107-021227.mp4
Testing
Reviewer Validations
Verify biometrics now works for Android 15 devices, and still works the same for other Android versions and iOS.
PR Checklist
Reviewer: Confirm the items below as you review
For QA
Run a build for this branch