Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug/9925-Android15Biometrics #10061

Merged
merged 18 commits into from
Nov 13, 2024
Merged

bug/9925-Android15Biometrics #10061

merged 18 commits into from
Nov 13, 2024

Conversation

theodur
Copy link
Contributor

@theodur theodur commented Oct 29, 2024

Description of Change

Fixes biometrics not working on Android 15 devices. The root issue seems to be with the react-native-keychain library, so an actual fix will need to come from the library. After upgrading to the latest version of react-native-keychain, it seems like biometrics works intermittently on Android 15 devices. What this PR does is add retry functionality for retrieving the refresh token from biometrics. This allows 3 attempts at retrieving the refresh token, which from what I've seen should be enough for successful retrieval on Android 15.

During the biometric retries, users would be stuck on the login screen without any indication of what's happening, so I added functionality to display a loading icon on the login screen whenever the refresh token if being retrieved from biometrics. This way, it won't seem like there is a long delay before the sign in process is actually continued.

Screenshots/Video

Before

screen-20241107-021715.mp4

After

screen-20241107-021227.mp4

Testing

  • Tested on iOS
  • Tested on Android

Reviewer Validations

Verify biometrics now works for Android 15 devices, and still works the same for other Android versions and iOS.

PR Checklist

Reviewer: Confirm the items below as you review

  • PR is connected to issue(s)
  • Tests are included to cover this change (when possible)
  • No magic strings (All string unions follow the Union -> Constant type pattern)
  • No secrets or API keys are checked in
  • All imports are absolute (no relative imports)
  • New functions and Redux work have proper TSDoc annotations

For QA

Run a build for this branch

@theodur theodur marked this pull request as ready for review November 7, 2024 17:35
@theodur theodur requested review from a team as code owners November 7, 2024 17:35
@github-actions github-actions bot added the FE-With QA A PR waiting for QA Activity label Nov 12, 2024
@github-actions github-actions bot added FE-Ready to Merge and removed FE-With QA A PR waiting for QA Activity labels Nov 13, 2024
@theodur theodur merged commit ff79677 into develop Nov 13, 2024
44 of 48 checks passed
@theodur theodur deleted the bug/9925-Android15Biometrics branch November 13, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants