Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore/9616-rollback-link-with-analytics-component #9626

Merged
merged 7 commits into from
Sep 23, 2024
Merged

chore/9616-rollback-link-with-analytics-component #9626

merged 7 commits into from
Sep 23, 2024

Conversation

alexandec
Copy link
Contributor

@alexandec alexandec commented Sep 19, 2024 •
edited
Loading

Description of Change

Create useOldLinkComponent feature flag. When flag is off, use the Design System's Link component. When flag is on, use the old ClickForActionLinkDeprecated component.

Screenshots/Video

Crisis Line with flag off and on:
  

Appointments with flag off and on:
  

Testing

  • Tested on iOS
  • Tested on Android

Reviewer Validations

  • All links in app display and function correctly, including analytics, with useOldLinkComponent turned off
  • All links in app display and function correctly, including analytics, with useOldLinkComponent turned on
  • Message attachments and links inside messages also need to be tested

PR Checklist

Reviewer: Confirm the items below as you review

  • PR is connected to issue(s)
  • Tests are included to cover this change (when possible)
  • No magic strings (All string unions follow the Union -> Constant type pattern)
  • No secrets or API keys are checked in
  • All imports are absolute (no relative imports)
  • New functions and Redux work have proper TSDoc annotations

For QA

Run a build for this branch

@alexandec alexandec requested review from a team as code owners September 19, 2024 19:28
@alexandec alexandec force-pushed the chore/9616-rollback-link-with-analytics-component branch from 602728a to 62fefcd Compare September 19, 2024 19:29
@github-actions github-actions bot added FE-With QA A PR waiting for QA Activity and removed FE-Needs Review labels Sep 19, 2024
TKDickson
TKDickson approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@TKDickson TKDickson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ready to merge to develop

@github-actions github-actions bot added FE-Ready to Merge and removed FE-With QA A PR waiting for QA Activity labels Sep 23, 2024
@alexandec alexandec merged commit 0f7e296 into develop Sep 23, 2024
79 of 87 checks passed
@alexandec alexandec deleted the chore/9616-rollback-link-with-analytics-component branch September 23, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TKDickson TKDickson TKDickson approved these changes

@Sparowhawk Sparowhawk Sparowhawk approved these changes

@timwright12 timwright12 Awaiting requested review from timwright12 timwright12 is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@theodur theodur Awaiting requested review from theodur theodur is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@dumathane dumathane Awaiting requested review from dumathane dumathane is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@cadibemma cadibemma Awaiting requested review from cadibemma cadibemma is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

Assignees
No one assigned
Labels
FE-Ready to Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexandec @Sparowhawk @TKDickson