Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug/7832-UpdatePaymentsAppHeadings #9662

Merged
merged 2 commits into from
Sep 25, 2024
Merged

bug/7832-UpdatePaymentsAppHeadings #9662

merged 2 commits into from
Sep 25, 2024

Conversation

alexandec
Copy link
Contributor

@alexandec alexandec commented Sep 23, 2024 •
edited
Loading

Description of Change

Add header role to headings on the Payment Details screen where the role was missing.

Screenshots/Video

Before:

payment-details-before.mov

After:

payment-details-after.mov

Testing

  • Tested on iOS
  • Tested on Android

Reviewer Validations

Amount, Method, Bank, and Account should be announced as headings.

PR Checklist

Reviewer: Confirm the items below as you review

  • PR is connected to issue(s)
  • Tests are included to cover this change (when possible)
  • No magic strings (All string unions follow the Union -> Constant type pattern)
  • No secrets or API keys are checked in
  • All imports are absolute (no relative imports)
  • New functions and Redux work have proper TSDoc annotations

For QA

Run a build for this branch

@alexandec alexandec requested review from a team as code owners September 23, 2024 22:27
@Sparowhawk Sparowhawk added FE-With QA A PR waiting for QA Activity and removed FE-Needs Review labels Sep 24, 2024
@github-actions github-actions bot added FE-Ready to Merge and removed FE-With QA A PR waiting for QA Activity labels Sep 24, 2024
@Sparowhawk Sparowhawk merged commit f70c1db into develop Sep 25, 2024
35 of 36 checks passed
@Sparowhawk Sparowhawk deleted the bug/7832-UpdatePaymentsAppHeadings branch September 25, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sparowhawk Sparowhawk Sparowhawk approved these changes

@rbontrager rbontrager rbontrager approved these changes

@timwright12 timwright12 Awaiting requested review from timwright12 timwright12 is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@theodur theodur Awaiting requested review from theodur theodur is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@dumathane dumathane Awaiting requested review from dumathane dumathane is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@cadibemma cadibemma Awaiting requested review from cadibemma cadibemma is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

Assignees
No one assigned
Labels
FE-Ready to Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexandec @rbontrager @Sparowhawk