CU: Audit common.json and remove unused strings #9785
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Audit the
common.json
translation key file and look for unused strings. Using the following process..ts
and.tsx
files and remove them from thecommon.json
automaticallyScreenshots/Video
N/A
Testing
Ran an simple
yarn test
to ensure that keys used in tests were not removedTested on iOS
Tested on Android
Reviewer Validations
If any of the removed keys are known to be dynamically generated call it out so that they can be kept and possibly refactored to a way that the translation key is not dynamically generated.
PR Checklist
Reviewer: Confirm the items below as you review
For QA
Run a build for this branch