feature/9759-Add AppointmentMedicationWording to InPerson Phone & CC

[juancstlm-a6]

Description of Change

Update the content in a In person Appointment and Community Care Appointment details to include the following component when Upcoming and Cancelled status. Existing content/wording relating to medication wording will be removed in favor of only the component listed below.

Screenshots/Video

iOS

9759-iOS.mp4

Android

9759-Android.mp4

Testing

• Updated test for In Person, Community Care, and Phone Tests to account for new component showing on Upcoming and Cancelled statuses
• Tested on iOS
• Tested on Android

Reviewer Validations

• Update In person Appointment details to include the "Medication wording" component for Upcoming and Cancelled status
• Update Community Care Appointment details to include the "Medication wording" component Upcoming and Cancelled status
• Update Phone Appointment details to include the "Medication wording" component Upcoming and Cancelled status
• Update VideoVA Appointment details to include the "Medication wording" component Upcoming and Cancelled status
• "Medication wording" component contains a link that opens https://www.va.gov/resources/what-should-i-bring-to-my-health-care-appointments/ in a in app web view
• ENV file is updated with the appropriate link

PR Checklist

Reviewer: Confirm the items below as you review

• PR is connected to issue(s)
• Tests are included to cover this change (when possible)
• No magic strings (All string unions follow the Union -> Constant type pattern)
• No secrets or API keys are checked in
• All imports are absolute (no relative imports)
• New functions and Redux work have proper TSDoc annotations

For QA

Run a build for this branch

[TKDickson]

@juancstlm-a6 I was taking a look at this ticket for testing assignment, and noticed that the spacing between the content and the link doesn't meet our minimum requirements. You'll need to increase it to match the spacing on the mock in the design library, FYI: https://www.figma.com/design/QVLPB3eOunmKrgQOuOt0SU/Flagship-Library---%F0%9F%93%90-Resource---VA-Mobile?node-id=4598-17424&t=rZu6KwpJc4zhhOzC-4

[juancstlm-a6]

@juancstlm-a6 I was taking a look at this ticket for testing assignment, and noticed that the spacing between the content and the link doesn't meet our minimum requirements. You'll need to increase it to match the spacing on the mock in the design library, FYI: https://www.figma.com/design/QVLPB3eOunmKrgQOuOt0SU/Flagship-Library---%F0%9F%93%90-Resource---VA-Mobile?node-id=4598-17424&t=rZu6KwpJc4zhhOzC-4

Do you mean this spacing ? or the one below the link ?

[TKDickson]

@juancstlm-a6 yep that spacing.

[juancstlm-a6]

@TKDickson It seems that it already is the correct spacing. Below is a gif of the simulator overlayed on the figma file while I toggle the opacity on and off. I lined up the headers and the link icon and it seems dead on to me. Would you suggest increasing or decreasing the spacing ?

The spacing that I see incorrect is from the "Details you shared with ..." and the "TTY link" happy to fix that in a separate ticket.

[TKDickson]

@juancstlm-a6 yeah your spacing looks good. I was looking at the Figma designs linked in the ticket, which don't have the correct spacing, and assumed that you had built to match those; hadn't brought up the branch.

[dumathane]

@alexandec can you PR this for Juan this week?

[alexandec]

Looks good overall, just a couple test-related things:

• Could you update the E2E tests to check for the new content and link?
• For the unit tests, we have a new best practice of calling the translation function instead of checking for a string. See docs here: https://department-of-veterans-affairs.github.io/va-mobile-app/docs/Engineering/FrontEnd/Testing/UnitTesting#targeting-by-translated-text

[juancstlm-a6]

@alexandec Thanks for the review. I have updated the PR to address your points.
I added e2e tests to check that the components show in the right places I left this checking against text as trying to tests against the translation function had errors and I didn't see any existing e2e test that do this.
Updated the unit test to check against the translation function (this is great btw)

[alexandec]

@juancstlm-a6 looks good, thanks for making those changes. We haven't tried using the t function in E2E tests yet, no worries there