Bump react-native-haptic-feedback from 2.2.0 to 2.3.3 in /VAMobile #9873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [react-native-haptic-feedback](https://github.com/mkuczera/react-native-haptic-feedback) from 2.2.0 to 2.3.3. - [Release notes](https://github.com/mkuczera/react-native-haptic-feedback/releases) - [Commits](mkuczera/react-native-haptic-feedback@v2.2.0...v2.3.3) --- updated-dependencies: - dependency-name: react-native-haptic-feedback dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
added
the
dependencies
dependabot
bot
requested review from
alexandec,
theodur,
dumathane,
cadibemma and
Sparowhawk
|
@theodur I updated the pods and I am still getting the error if you can take a look |
|
@Sparowhawk The issue was the package needed to be mocked in our unit test setup. They must have changed something with how the package is referenced in the latest release. I'm running Detox tests to make sure everything passes before approving and merging. Edit: This is one of those packages that, even though should work with a minor update, should still be tested physically, since there's no way to be certain that haptics still works from the tests. I kicked on an on-demand build. |
theodur
approved these changes
Oct 31, 2024
theodur
deleted the
dependabot/npm_and_yarn/VAMobile/react-native-haptic-feedback-2.3.3
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps react-native-haptic-feedback from 2.2.0 to 2.3.3.
Release notes
Sourced from react-native-haptic-feedback's releases.
Commits
8cdf0f3remove yarn.lock7668b09adjust example project usage5bb92f6Merge pull request #139 from huextrat/fix/missing-types-export6c5b540fix: export types from index3254566version bumpd1516d5Merge pull request #135 from huextrat/fix/types65c8b10Merge pull request #136 from huextrat/build/bump-compile-target-sdkae7a3f8build(android): bump compile & target SDK to 3416508f2fix: types55b7150Merge pull request #133 from WoLewicki/@wolewicki/fix-newarchDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)