Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-16858 Fix VBA banner typo. #16860

Merged
merged 1 commit into from
Jan 17, 2024
Merged

VACMS-16858 Fix VBA banner typo. #16860

merged 1 commit into from
Jan 17, 2024

Conversation

swirtSJW
Copy link
Contributor

@swirtSJW swirtSJW commented Jan 16, 2024

Description

Relates to #16858

Testing done

Screenshots

QA steps

What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?

As an admin

  1. Edit a VBA facility
  2. Scroll down the banner section and check the box to add the banner.
    • Validate that under type of alerts, it has "Warning alerts:"

image

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.
  • If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

Is this PR blocked by another PR?

  • DO NOT MERGE

Does this PR need review from a Product Owner

  • Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

  • Yes, and it's written in issue ____ and queued for publication.
    • Merge and ping the UX writer so they are ready to publish after deployment
  • Yes, but it hasn't yet been written
    • Don't merge yet -- ping the UX writer to write and queue content
  • No announcement is needed for this code change.
    • Merge & carry on unburdened by announcements

@swirtSJW swirtSJW self-assigned this Jan 16, 2024
@swirtSJW swirtSJW marked this pull request as ready for review January 16, 2024 22:18
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 16, 2024 22:18 Destroyed
@swirtSJW swirtSJW requested a review from a team as a code owner January 16, 2024 22:18
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 17, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 17, 2024
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 17, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 17, 2024
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 17, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 17, 2024
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 17, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 17, 2024
@swirtSJW swirtSJW requested a review from omahane January 17, 2024 22:24
Copy link
Contributor

@omahane omahane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The colon looks great!

@swirtSJW
Copy link
Contributor Author

image

@swirtSJW swirtSJW merged commit c33d8d0 into main Jan 17, 2024
13 of 18 checks passed
@swirtSJW swirtSJW deleted the VACMS-16858-vba-banner-typo branch January 17, 2024 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants