Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS_16449: updated date formats #16946

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

edmund-dunn
Copy link
Contributor

@edmund-dunn edmund-dunn commented Jan 22, 2024

Description

Closes #16449.

Testing done

Tested locally.

Screenshots

CleanShot2024-01-22at07 42 57

QA steps

What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?

As user uid with user_role

  1. Navigate to /admin/people and click Download CSV
    • Validate that the dates in CSV are formatted like 2023-11-20 10:54:27
  2. Then click Download CSV of sll Users
    • Validate that the dates in CSV are formatted like 2023-11-20 10:54:27

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.
  • If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

Is this PR blocked by another PR?

  • DO NOT MERGE

Does this PR need review from a Product Owner

  • Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

  • Yes, and it's written in issue ____ and queued for publication.
    • Merge and ping the UX writer so they are ready to publish after deployment
  • Yes, but it hasn't yet been written
    • Don't merge yet -- ping the UX writer to write and queue content
  • No announcement is needed for this code change.
    • Merge & carry on unburdened by announcements

@edmund-dunn edmund-dunn self-assigned this Jan 22, 2024
@edmund-dunn edmund-dunn linked an issue Jan 22, 2024 that may be closed by this pull request
5 tasks
@edmund-dunn edmund-dunn added CMS Team CMS Product team that manages both editor exp and devops Drupal engineering CMS team practice area labels Jan 22, 2024
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 22, 2024 15:42 Destroyed
Copy link
Contributor

@laflannery laflannery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested using the report indicated in the QA steps and tested a couple others just in case. They look good to me

@edmund-dunn edmund-dunn merged commit e11ef26 into main Jan 22, 2024
25 checks passed
@edmund-dunn edmund-dunn deleted the 16449-update-date-format-in-csv-export-file branch January 22, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMS Team CMS Product team that manages both editor exp and devops Drupal engineering CMS team practice area
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update date format in CSV export file
3 participants