Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-16726: Remove block_content_permissions from composer. #17033

Merged

Conversation

Becapa
Copy link
Contributor

@Becapa Becapa commented Jan 25, 2024

Description

Relates to #16726.

QA steps

As an administrator

  1. Browse to the extensions page (/admin/modules)
    • Validate that Block Content Permissions is no longer listed anywhere on the page.

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.
  • If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

Is this PR blocked by another PR?

  • DO NOT MERGE

Does this PR need review from a Product Owner

  • Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

  • Yes, and it's written in issue ____ and queued for publication.
    • Merge and ping the UX writer so they are ready to publish after deployment
  • Yes, but it hasn't yet been written
    • Don't merge yet -- ping the UX writer to write and queue content
  • No announcement is needed for this code change.
    • Merge & carry on unburdened by announcements

@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 25, 2024 19:09 Destroyed
@Becapa Becapa requested a review from dsasser January 25, 2024 19:09
@Becapa Becapa force-pushed the VACMS-16726-remove-block_content_permissions-from-composer branch from 8fd72f0 to 5040c2f Compare January 25, 2024 21:30
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 25, 2024 21:30 Destroyed
@dsasser
Copy link
Contributor

dsasser commented Jan 25, 2024

Looks good:

Screenshot 2024-01-25 at 3 12 53 PM

@va-cms-bot va-cms-bot added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 26, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 26, 2024
@Becapa Becapa merged commit 2de3835 into main Jan 26, 2024
20 checks passed
@Becapa Becapa deleted the VACMS-16726-remove-block_content_permissions-from-composer branch January 26, 2024 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants