Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

17774 remove simplesamlphp salt and admin password from vagov cms and changes values #17789

Conversation

edmund-dunn
Copy link
Contributor

Description

Relates to #17774

Testing done

Tested on test infrastructure

Screenshots

QA steps

What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?

Cannot be QAd on tugboat. If it passes all automated testing it should be good.

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.
  • If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

Is this PR blocked by another PR?

  • DO NOT MERGE

Does this PR need review from a Product Owner

  • Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

  • Yes, and it's written in issue ____ and queued for publication.
    • Merge and ping the UX writer so they are ready to publish after deployment
  • Yes, but it hasn't yet been written
    • Don't merge yet -- ping the UX writer to write and queue content
  • No announcement is needed for this code change.
    • Merge & carry on unburdened by announcements

@edmund-dunn edmund-dunn self-assigned this Apr 9, 2024
@edmund-dunn edmund-dunn requested a review from a team as a code owner April 9, 2024 17:28
@va-cms-bot va-cms-bot temporarily deployed to Tugboat April 9, 2024 17:28 Destroyed
Copy link
Contributor

@timcosgrove timcosgrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added suggestions for comments to explain what's happening.

@va-cms-bot va-cms-bot temporarily deployed to Tugboat April 9, 2024 17:47 Destroyed
@github-actions github-actions bot added the CMS Team CMS Product team that manages both editor exp and devops label Apr 9, 2024
@edmund-dunn edmund-dunn merged commit 7ad46d8 into main Apr 9, 2024
18 checks passed
@edmund-dunn edmund-dunn deleted the 17774-remove-simplesamlphp-salt-and-admin-password-from-vagov-cms-and-changes-values branch April 9, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMS Team CMS Product team that manages both editor exp and devops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove simplesamlphp salt and admin password from va.gov-cms and changes values
3 participants