VACMS-17605: Prevent duplicate appt phone #17856

omahane · 2024-04-15T18:46:14Z

Description

Relates to #17605

(Note: This also captures work from main to rebase the integration branch.)

Testing done

Manually

Screenshots

From /admin/config/development/batch_operations/log:

QA steps

Run the following command in the Tugboat terminal:
drush codit-batch-operations:run Vacms15559MigrateServiceLocationFromNodeToParagraph
Confirm that the log looks like this in the terminal:

Processed item_322. [0%] [1/16021]
Processed item_323. [0%] [2/16021]
Processed item_348. [0%] [3/16021]
Processed item_349. [0%] [4/16021]
Processed item_350. [0%] [5/16021]

Go to the Codit Batch Operations log
Confirm that the log looks the same as it does in the terminal
Let it run.
If your Tugboat gets disconnected, go back to the Codit Batch Operations log
Refresh the page
Confirm that the log continues to show new items
When it's done, go to the Service locations audit
Confirm that no phone numbers are duplicated

Definition of Done

Documentation has been updated, if applicable.
Tests have been added if necessary.
Automated tests have passed.
Code Quality Tests have passed.
Acceptance Criteria in related issue are met.
Manual Code Review Approved.
If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

* VACMS:14704: Adding service modalities * VACMS-14704: Adds vocabulary * VACMS-14704: Adds free-text fields. * VACMS-14704: Update langage around service delivery * VACMS-14704: Updates taxonomy label and description

* VACMS-14704: Adding service location fields (#15599) * VACMS:14704: Adding service modalities * VACMS-14704: Adds vocabulary * VACMS-14704: Adds free-text fields. * VACMS-14704: Update langage around service delivery * VACMS-14704: Updates taxonomy label and description * VACMS-16348: Removes unnecessary and undesired fields * VACMS-16348: Adds service options, office hours and virtual support * VACMS-16348: Adds appointment fields * VACMS-16348: Adds online scheduling field * VACMS-16348: Adds a necessary question mark * VACMS-16348: Updates description for office visits

* VACMS-16451: Adds service location audit * VACMS-16451: Fixes export and adds filters * VACMS-16451: Reapplied content moderation state filter, removed published * VACMS-16451: Adds online scheduling fields * VACMS-16451: Changes the weight of the view in the menu * VACMS-16451: Adds table caption and link in download * Update config/sync/views.view.service_locations_audit.yml Co-authored-by: Steve Wirt <[email protected]> --------- Co-authored-by: Steve Wirt <[email protected]>

* Add post_update hook to move facility service location data * Add placeholder methods and mapping * Adding more notes * VACMS-15559 FIXUP refactor into class. * VACMS-15559 Refactory functions to scipt library. * Add new map to value function to script-library. * VACMS-15559 Remove conflation of new revision and new node. * VACMS-15559 Add all migrated fields to migration. * VACMS-15559 Programatically shut off queue checks and processing. * VACMS-15559 Move deploy function to script. * VACMS-15559 Update audit, make sortable, add editor updated. * VACMS-15559 Cleaned up function names and some comments. * VACMS-15559 Fix incorrect office_visits parameter. * VACMS-15559 Make service location audit headers sticky. * VACMS-15559 Fix forward revision. * VACMS-15559 Fix the timing on grabing the lastes revision. * VACMS-15559 Fix recent changes View to sort by revision id, not time. * VACMS-15559 Carry forward draft revision log message.

* VACMS-14704: Adding service location fields (#15599) * VACMS:14704: Adding service modalities * VACMS-14704: Adds vocabulary * VACMS-14704: Adds free-text fields. * VACMS-14704: Update langage around service delivery * VACMS-14704: Updates taxonomy label and description * VACMS-16348: Removes unnecessary and undesired fields * VACMS-16348: Shows Custom text when Customize text is selected * VACMS-16348: Trying to get the default text * VACMS-16348: Adds default text to Service Locations for VAMC facility health and Service region * VACMS-16348: Removes VAMC Facility Health Service-level appointment code * VACMS-16348: Adds VBA Facility service appt lead-in default text * VACMS-16348: Adds VBA FAcility service appt default text UX * VACMS-16348: DRYing off this code for the different content types and fields * VACMS-16348: Adds nonclinical service default text field * VACMS-16348: Restores the errant revision_log and adds right field for vba_facility_service * VACMS-16348: Moves work out of backend and vamc and into facilities * VACMS-16348: Trying to get paragraph validation to work * VACMS-16348: Adds required state to custom text * VACMS-16348: Removes text validation, as not working, for now * VACMS-16348: Removing commented out code

…tion (#17225) * VACMS-17142: Update cypress test to use phone number in service locations * VACMS-17142: Hide VAMC Facility Health Service fields that are no longer in use. * VACMS-17142: Have the view_display mirror the form_display. * VACMS-17142: Add revision_log back. * VACMS-17142: Update service location paragraph view display to mirror form display.

…17249)

* VACMS-17114: Adds appointment text * VACMS-17114: Adds walk-ins and online scheduling refactored * VACMS-17114: Unfinished work on phones * VACMS-17114: Adds online scheduling available (untested) * VACMS-17114: Tested one row successfully * VACMS-17144: Refactor to remove unnecessary methods, tested row 2 successfully * VACMS-17114: Updates how Office Visits are captued * VACMS-17114: Refactors office visits logic to be more ... logical * VACMS-17114: Accounts for false then true then false for online scheduling * VACMS-17114: Changes online scheduling to string * VACMS-17114: Changes online scheduling to check for empty * VACMS-17114: Getting logic of phone type to work * VACMS-17114: Fixes the logic of the appointment lead in text * VACMS-17114: Test of using method * VACMS-17114: Adds logic for getting ALL the phone numbers * VACMS-17114: Getting all numbers. Not passing main more than once. But empty array. * VACMS-17114: Main phones won't duplicate. Others are shwowing. * VACMS-17114: Moves service-level work to own function * VACMS-17114: Changes the way phones are added to stop queue processing from throwing WSOD * VACMS-17114: Refactors getting phones for service appointment

* Bump va-gov/content-build from 0.0.3450 to 0.0.3451 (#17471) Bumps [va-gov/content-build](https://github.com/department-of-veterans-affairs/content-build) from 0.0.3450 to 0.0.3451. - [Release notes](https://github.com/department-of-veterans-affairs/content-build/releases) - [Commits](department-of-veterans-affairs/content-build@v0.0.3450...v0.0.3451) --- updated-dependencies: - dependency-name: va-gov/content-build dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump drupal/hook_event_dispatcher from 4.0.0-rc1 to 4.0.0 (#17428) * Bump drupal/hook_event_dispatcher from 4.0.0-rc1 to 4.0.0 Bumps drupal/hook_event_dispatcher from 4.0.0-rc1 to 4.0.0. --- updated-dependencies: - dependency-name: drupal/hook_event_dispatcher dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * removed unnecessary patch * updated composer.lock * updated composer.lock * updated composer.lock --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Edmund Dunn <[email protected]> * Bump aws-actions/configure-aws-credentials from 4.0.1 to 4.0.2 (#17273) Bumps [aws-actions/configure-aws-credentials](https://github.com/aws-actions/configure-aws-credentials) from 4.0.1 to 4.0.2. - [Release notes](https://github.com/aws-actions/configure-aws-credentials/releases) - [Changelog](https://github.com/aws-actions/configure-aws-credentials/blob/main/CHANGELOG.md) - [Commits](aws-actions/configure-aws-credentials@010d0da...e3dd6a4) --- updated-dependencies: - dependency-name: aws-actions/configure-aws-credentials dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Edmund Dunn <[email protected]> * Bump phpstan/phpstan from 1.10.59 to 1.10.60 (#17472) Bumps [phpstan/phpstan](https://github.com/phpstan/phpstan) from 1.10.59 to 1.10.60. - [Release notes](https://github.com/phpstan/phpstan/releases) - [Changelog](https://github.com/phpstan/phpstan/blob/1.11.x/CHANGELOG.md) - [Commits](phpstan/phpstan@1.10.59...1.10.60) --- updated-dependencies: - dependency-name: phpstan/phpstan dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump actions/setup-node from 4.0.1 to 4.0.2 (#17205) Bumps [actions/setup-node](https://github.com/actions/setup-node) from 4.0.1 to 4.0.2. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@b39b52d...60edb5d) --- updated-dependencies: - dependency-name: actions/setup-node dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Edmund Dunn <[email protected]> * VACMS-17323: Updates module with fixes for button (#17451) * VACMS-17323: Updates module with fixes for button * VACMS-17325: Updates the default displays of content types and paragraphs * VACMS-17325: Adds other displays settings * Adding in VAMC Top Task pages (#17470) * Billing and Insurance * Update views.view.non_clinical_services.yml * Update core.entity_view_display.node.vamc_system_billing_insurance.search_index.yml * Update core.entity_view_display.node.vamc_system_billing_insurance.default.yml * VACMS-17325: Updates service location hours display --------- Co-authored-by: Dave Pickett <[email protected]> * VACMS-14083: Upgrades address module to version 2.0 (#17393) * VACMS-14083: Upgrade address module with dependencies via composer (#17297) * VACMS-14083: Upgrade address module with dependencies via composer * VACMS-14083: Updates composer.lock * VACMS-17191: Back end changes for address module upgrade (#17392) * VACMS-17191: Hide address line 3 for all address fields. * VACMS-17191: Hide address line 3 for second NCA address field. * VACMS-14083: Update composer.lock * VACMS-14083: Update composer.lock --------- Co-authored-by: Christian Burk <[email protected]> * Revert hook event dispatcher update (#17484) * Revert "Bump drupal/hook_event_dispatcher from 4.0.0-rc1 to 4.0.0 (#17428)" This reverts commit 4d1cb3a. * updated composer.lock * updated composer files * Bump va-gov/content-build from 0.0.3451 to 0.0.3452 (#17492) Bumps [va-gov/content-build](https://github.com/department-of-veterans-affairs/content-build) from 0.0.3451 to 0.0.3452. - [Release notes](https://github.com/department-of-veterans-affairs/content-build/releases) - [Commits](department-of-veterans-affairs/content-build@v0.0.3451...v0.0.3452) --- updated-dependencies: - dependency-name: va-gov/content-build dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * VACMS-16348: Service location ux enhancements (#17048) * VACMS-14704: Adding service location fields (#15599) * VACMS:14704: Adding service modalities * VACMS-14704: Adds vocabulary * VACMS-14704: Adds free-text fields. * VACMS-14704: Update langage around service delivery * VACMS-14704: Updates taxonomy label and description * VACMS-16348: Removes unnecessary and undesired fields * VACMS-16348: Shows Custom text when Customize text is selected * VACMS-16348: Trying to get the default text * VACMS-16348: Adds default text to Service Locations for VAMC facility health and Service region * VACMS-16348: Removes VAMC Facility Health Service-level appointment code * VACMS-16348: Adds VBA Facility service appt lead-in default text * VACMS-16348: Adds VBA FAcility service appt default text UX * VACMS-16348: DRYing off this code for the different content types and fields * VACMS-16348: Adds nonclinical service default text field * VACMS-16348: Restores the errant revision_log and adds right field for vba_facility_service * VACMS-16348: Moves work out of backend and vamc and into facilities * VACMS-16348: Trying to get paragraph validation to work * VACMS-16348: Adds required state to custom text * VACMS-16348: Removes text validation, as not working, for now * VACMS-16348: Removing commented out code * VACMS-17114: Adds empty string to prevent nulls --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Edmund Dunn <[email protected]> Co-authored-by: Dave Pickett <[email protected]> Co-authored-by: Michael Kinnunen <[email protected]>

Bumps [va-gov/content-build](https://github.com/department-of-veterans-affairs/content-build) from 0.0.3481 to 0.0.3482. - [Release notes](https://github.com/department-of-veterans-affairs/content-build/releases) - [Commits](department-of-veterans-affairs/content-build@v0.0.3481...v0.0.3482) --- updated-dependencies: - dependency-name: va-gov/content-build dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* VACMS:14704: Adding service modalities * VACMS-14704: Adds vocabulary * VACMS-14704: Adds free-text fields. * VACMS-14704: Update langage around service delivery * VACMS-14704: Updates taxonomy label and description

* VACMS-14704: Adding service location fields (#15599) * VACMS:14704: Adding service modalities * VACMS-14704: Adds vocabulary * VACMS-14704: Adds free-text fields. * VACMS-14704: Update langage around service delivery * VACMS-14704: Updates taxonomy label and description * VACMS-16348: Removes unnecessary and undesired fields * VACMS-16348: Adds service options, office hours and virtual support * VACMS-16348: Adds appointment fields * VACMS-16348: Adds online scheduling field * VACMS-16348: Adds a necessary question mark * VACMS-16348: Updates description for office visits

* VACMS-16451: Adds service location audit * VACMS-16451: Fixes export and adds filters * VACMS-16451: Reapplied content moderation state filter, removed published * VACMS-16451: Adds online scheduling fields * VACMS-16451: Changes the weight of the view in the menu * VACMS-16451: Adds table caption and link in download * Update config/sync/views.view.service_locations_audit.yml Co-authored-by: Steve Wirt <[email protected]> --------- Co-authored-by: Steve Wirt <[email protected]>

* Add post_update hook to move facility service location data * Add placeholder methods and mapping * Adding more notes * VACMS-15559 FIXUP refactor into class. * VACMS-15559 Refactory functions to scipt library. * Add new map to value function to script-library. * VACMS-15559 Remove conflation of new revision and new node. * VACMS-15559 Add all migrated fields to migration. * VACMS-15559 Programatically shut off queue checks and processing. * VACMS-15559 Move deploy function to script. * VACMS-15559 Update audit, make sortable, add editor updated. * VACMS-15559 Cleaned up function names and some comments. * VACMS-15559 Fix incorrect office_visits parameter. * VACMS-15559 Make service location audit headers sticky. * VACMS-15559 Fix forward revision. * VACMS-15559 Fix the timing on grabing the lastes revision. * VACMS-15559 Fix recent changes View to sort by revision id, not time. * VACMS-15559 Carry forward draft revision log message.

* VACMS-14704: Adding service location fields (#15599) * VACMS:14704: Adding service modalities * VACMS-14704: Adds vocabulary * VACMS-14704: Adds free-text fields. * VACMS-14704: Update langage around service delivery * VACMS-14704: Updates taxonomy label and description * VACMS-16348: Removes unnecessary and undesired fields * VACMS-16348: Shows Custom text when Customize text is selected * VACMS-16348: Trying to get the default text * VACMS-16348: Adds default text to Service Locations for VAMC facility health and Service region * VACMS-16348: Removes VAMC Facility Health Service-level appointment code * VACMS-16348: Adds VBA Facility service appt lead-in default text * VACMS-16348: Adds VBA FAcility service appt default text UX * VACMS-16348: DRYing off this code for the different content types and fields * VACMS-16348: Adds nonclinical service default text field * VACMS-16348: Restores the errant revision_log and adds right field for vba_facility_service * VACMS-16348: Moves work out of backend and vamc and into facilities * VACMS-16348: Trying to get paragraph validation to work * VACMS-16348: Adds required state to custom text * VACMS-16348: Removes text validation, as not working, for now * VACMS-16348: Removing commented out code

…tion (#17225) * VACMS-17142: Update cypress test to use phone number in service locations * VACMS-17142: Hide VAMC Facility Health Service fields that are no longer in use. * VACMS-17142: Have the view_display mirror the form_display. * VACMS-17142: Add revision_log back. * VACMS-17142: Update service location paragraph view display to mirror form display.

…17249)

* VACMS-17114: Adds appointment text * VACMS-17114: Adds walk-ins and online scheduling refactored * VACMS-17114: Unfinished work on phones * VACMS-17114: Adds online scheduling available (untested) * VACMS-17114: Tested one row successfully * VACMS-17144: Refactor to remove unnecessary methods, tested row 2 successfully * VACMS-17114: Updates how Office Visits are captued * VACMS-17114: Refactors office visits logic to be more ... logical * VACMS-17114: Accounts for false then true then false for online scheduling * VACMS-17114: Changes online scheduling to string * VACMS-17114: Changes online scheduling to check for empty * VACMS-17114: Getting logic of phone type to work * VACMS-17114: Fixes the logic of the appointment lead in text * VACMS-17114: Test of using method * VACMS-17114: Adds logic for getting ALL the phone numbers * VACMS-17114: Getting all numbers. Not passing main more than once. But empty array. * VACMS-17114: Main phones won't duplicate. Others are shwowing. * VACMS-17114: Moves service-level work to own function * VACMS-17114: Changes the way phones are added to stop queue processing from throwing WSOD * VACMS-17114: Refactors getting phones for service appointment

* Bump va-gov/content-build from 0.0.3450 to 0.0.3451 (#17471) Bumps [va-gov/content-build](https://github.com/department-of-veterans-affairs/content-build) from 0.0.3450 to 0.0.3451. - [Release notes](https://github.com/department-of-veterans-affairs/content-build/releases) - [Commits](department-of-veterans-affairs/content-build@v0.0.3450...v0.0.3451) --- updated-dependencies: - dependency-name: va-gov/content-build dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump drupal/hook_event_dispatcher from 4.0.0-rc1 to 4.0.0 (#17428) * Bump drupal/hook_event_dispatcher from 4.0.0-rc1 to 4.0.0 Bumps drupal/hook_event_dispatcher from 4.0.0-rc1 to 4.0.0. --- updated-dependencies: - dependency-name: drupal/hook_event_dispatcher dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * removed unnecessary patch * updated composer.lock * updated composer.lock * updated composer.lock --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Edmund Dunn <[email protected]> * Bump aws-actions/configure-aws-credentials from 4.0.1 to 4.0.2 (#17273) Bumps [aws-actions/configure-aws-credentials](https://github.com/aws-actions/configure-aws-credentials) from 4.0.1 to 4.0.2. - [Release notes](https://github.com/aws-actions/configure-aws-credentials/releases) - [Changelog](https://github.com/aws-actions/configure-aws-credentials/blob/main/CHANGELOG.md) - [Commits](aws-actions/configure-aws-credentials@010d0da...e3dd6a4) --- updated-dependencies: - dependency-name: aws-actions/configure-aws-credentials dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Edmund Dunn <[email protected]> * Bump phpstan/phpstan from 1.10.59 to 1.10.60 (#17472) Bumps [phpstan/phpstan](https://github.com/phpstan/phpstan) from 1.10.59 to 1.10.60. - [Release notes](https://github.com/phpstan/phpstan/releases) - [Changelog](https://github.com/phpstan/phpstan/blob/1.11.x/CHANGELOG.md) - [Commits](phpstan/phpstan@1.10.59...1.10.60) --- updated-dependencies: - dependency-name: phpstan/phpstan dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump actions/setup-node from 4.0.1 to 4.0.2 (#17205) Bumps [actions/setup-node](https://github.com/actions/setup-node) from 4.0.1 to 4.0.2. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@b39b52d...60edb5d) --- updated-dependencies: - dependency-name: actions/setup-node dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Edmund Dunn <[email protected]> * VACMS-17323: Updates module with fixes for button (#17451) * VACMS-17323: Updates module with fixes for button * VACMS-17325: Updates the default displays of content types and paragraphs * VACMS-17325: Adds other displays settings * Adding in VAMC Top Task pages (#17470) * Billing and Insurance * Update views.view.non_clinical_services.yml * Update core.entity_view_display.node.vamc_system_billing_insurance.search_index.yml * Update core.entity_view_display.node.vamc_system_billing_insurance.default.yml * VACMS-17325: Updates service location hours display --------- Co-authored-by: Dave Pickett <[email protected]> * VACMS-14083: Upgrades address module to version 2.0 (#17393) * VACMS-14083: Upgrade address module with dependencies via composer (#17297) * VACMS-14083: Upgrade address module with dependencies via composer * VACMS-14083: Updates composer.lock * VACMS-17191: Back end changes for address module upgrade (#17392) * VACMS-17191: Hide address line 3 for all address fields. * VACMS-17191: Hide address line 3 for second NCA address field. * VACMS-14083: Update composer.lock * VACMS-14083: Update composer.lock --------- Co-authored-by: Christian Burk <[email protected]> * Revert hook event dispatcher update (#17484) * Revert "Bump drupal/hook_event_dispatcher from 4.0.0-rc1 to 4.0.0 (#17428)" This reverts commit 4d1cb3a. * updated composer.lock * updated composer files * Bump va-gov/content-build from 0.0.3451 to 0.0.3452 (#17492) Bumps [va-gov/content-build](https://github.com/department-of-veterans-affairs/content-build) from 0.0.3451 to 0.0.3452. - [Release notes](https://github.com/department-of-veterans-affairs/content-build/releases) - [Commits](department-of-veterans-affairs/content-build@v0.0.3451...v0.0.3452) --- updated-dependencies: - dependency-name: va-gov/content-build dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * VACMS-16348: Service location ux enhancements (#17048) * VACMS-14704: Adding service location fields (#15599) * VACMS:14704: Adding service modalities * VACMS-14704: Adds vocabulary * VACMS-14704: Adds free-text fields. * VACMS-14704: Update langage around service delivery * VACMS-14704: Updates taxonomy label and description * VACMS-16348: Removes unnecessary and undesired fields * VACMS-16348: Shows Custom text when Customize text is selected * VACMS-16348: Trying to get the default text * VACMS-16348: Adds default text to Service Locations for VAMC facility health and Service region * VACMS-16348: Removes VAMC Facility Health Service-level appointment code * VACMS-16348: Adds VBA Facility service appt lead-in default text * VACMS-16348: Adds VBA FAcility service appt default text UX * VACMS-16348: DRYing off this code for the different content types and fields * VACMS-16348: Adds nonclinical service default text field * VACMS-16348: Restores the errant revision_log and adds right field for vba_facility_service * VACMS-16348: Moves work out of backend and vamc and into facilities * VACMS-16348: Trying to get paragraph validation to work * VACMS-16348: Adds required state to custom text * VACMS-16348: Removes text validation, as not working, for now * VACMS-16348: Removing commented out code * VACMS-17114: Adds empty string to prevent nulls --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Edmund Dunn <[email protected]> Co-authored-by: Dave Pickett <[email protected]> Co-authored-by: Michael Kinnunen <[email protected]>

…duplicate-appt-phone

...ustom/va_gov_backend/src/cbo_scripts/Vacms15559MigrateServiceLocationFromNodeToParagraph.php

…59MigrateServiceLocationFromNodeToParagraph.php Co-authored-by: Steve Wirt <[email protected]>

...ustom/va_gov_backend/src/cbo_scripts/Vacms15559MigrateServiceLocationFromNodeToParagraph.php

omahane · 2024-04-19T21:08:30Z

We decided this was no necessary.

omahane and others added 12 commits April 12, 2024 10:45

VACMS-14704: Adding service location fields (#15599)

5a2def8

* VACMS:14704: Adding service modalities * VACMS-14704: Adds vocabulary * VACMS-14704: Adds free-text fields. * VACMS-14704: Update langage around service delivery * VACMS-14704: Updates taxonomy label and description

VACMS-15649: Removes free text fields from service location (#15676)

8aa4c43

VACMS-17241 Update service location migration script to keep state. (#…

038478c

…17249)

Update sitewide-crew-member-onboarding.md

2f13d23

va-cms-bot temporarily deployed to Tugboat April 15, 2024 18:46 Destroyed

omahane changed the base branch from main to integration-service-location April 15, 2024 18:46

omahane and others added 11 commits April 15, 2024 13:47

VACMS-14704: Adding service location fields (#15599)

ccc219e

* VACMS:14704: Adding service modalities * VACMS-14704: Adds vocabulary * VACMS-14704: Adds free-text fields. * VACMS-14704: Update langage around service delivery * VACMS-14704: Updates taxonomy label and description

VACMS-15649: Removes free text fields from service location (#15676)

c130ac6

VACMS-17241 Update service location migration script to keep state. (#…

85befc1

…17249)

VACMS-17605: Adds module for running and logging scripts

bc7593e

omahane force-pushed the VACMS-17605-prevent-duplicate-appt-phone branch from 430e3ec to bc7593e Compare April 15, 2024 18:48

va-cms-bot temporarily deployed to Tugboat April 15, 2024 18:48 Destroyed

va-cms-bot temporarily deployed to Tugboat April 15, 2024 18:55 Destroyed

VACMS-17605: Updates content-hash to pass test

bb29b18

omahane force-pushed the VACMS-17605-prevent-duplicate-appt-phone branch from 630cbe8 to bb29b18 Compare April 15, 2024 19:16

va-cms-bot temporarily deployed to Tugboat April 15, 2024 19:16 Destroyed

Merge branch 'integration-service-location' into VACMS-17605-prevent-…

51e0f36

…duplicate-appt-phone

va-cms-bot temporarily deployed to Tugboat April 15, 2024 19:18 Destroyed

github-actions bot added the Facilities Facilities products (VAMC, Vet Center, etc) label Apr 15, 2024

VACMS-17605: Adds configuration necessary for codit_batch_operations

957a493

va-cms-bot temporarily deployed to Tugboat April 15, 2024 20:41 Destroyed

omahane marked this pull request as ready for review April 15, 2024 21:01

omahane requested review from a team as code owners April 15, 2024 21:01

va-cms-bot temporarily deployed to Tugboat April 16, 2024 03:08 Destroyed

swirtSJW reviewed Apr 16, 2024

View reviewed changes

...ustom/va_gov_backend/src/cbo_scripts/Vacms15559MigrateServiceLocationFromNodeToParagraph.php Outdated Show resolved Hide resolved

Update docroot/modules/custom/va_gov_backend/src/cbo_scripts/Vacms155…

dfe01cd

…59MigrateServiceLocationFromNodeToParagraph.php Co-authored-by: Steve Wirt <[email protected]>

va-cms-bot temporarily deployed to Tugboat April 16, 2024 05:22 Destroyed

github-actions bot reviewed Apr 16, 2024

View reviewed changes

VACMS-17605: Indent tweaks.

61d86a4

va-cms-bot temporarily deployed to Tugboat April 16, 2024 05:33 Destroyed

omahane force-pushed the integration-service-location branch from e1b46a1 to bead97e Compare April 19, 2024 12:29

omahane closed this Apr 19, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

VACMS-17605: Prevent duplicate appt phone #17856

VACMS-17605: Prevent duplicate appt phone #17856

omahane commented Apr 15, 2024 •

edited

Loading

omahane commented Apr 19, 2024

VACMS-17605: Prevent duplicate appt phone #17856

VACMS-17605: Prevent duplicate appt phone #17856

Conversation

omahane commented Apr 15, 2024 • edited Loading

Description

Testing done

Screenshots

QA steps

Definition of Done

Select Team for PR review

omahane commented Apr 19, 2024

omahane commented Apr 15, 2024 •

edited

Loading