Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-17477: Updated character counter on News Releases #19126

Merged
merged 4 commits into from
Sep 9, 2024

Conversation

davidmpickett
Copy link
Contributor

@davidmpickett davidmpickett commented Sep 5, 2024

Description

Relates to #17477

Testing done

Manual testing of the News Release content type on Tugboat

Screenshots

Screenshot 2024-09-05 at 3 43 09 PM

Screenshot 2024-09-05 at 3 42 03 PM

QA steps

What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?

  1. Login to tugboat as a Content Admin (e.g. [email protected])
  2. Go to Content > Add Content > News release
    • Type in the Press Release Title field and confirm the character counter works as intended
    • Type in the Introduction field and confirm the character counter works as intended

Definition of Done

  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.

@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 5, 2024 20:21 Destroyed
@davidmpickett davidmpickett changed the title VACMS-17477: Updated character counter on New Releases VACMS-17477: Updated character counter on News Releases Sep 5, 2024
@davidmpickett davidmpickett requested a review from a team September 5, 2024 21:02
@davidmpickett davidmpickett self-assigned this Sep 5, 2024
@davidmpickett davidmpickett added sitewide Facilities Facilities products (VAMC, Vet Center, etc) News release CMS managed product owned by Facilities team labels Sep 5, 2024
@davidmpickett davidmpickett marked this pull request as ready for review September 5, 2024 21:18
Copy link
Contributor

@jv-agile6 jv-agile6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed

  • core.entity_form_display.node.press_release.default.yml
  • field.field.node.press_release.field_intro_text.yml
  • node.type.press_release.yml

Followed addition and subtraction to yml files. No defects noted.

@davidmpickett davidmpickett enabled auto-merge (squash) September 6, 2024 16:22
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 6, 2024 17:49 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 6, 2024 19:02 Destroyed
@davidmpickett davidmpickett force-pushed the VACMS-17477-news-release-character-counter branch from 07351be to 05df62b Compare September 6, 2024 19:49
@davidmpickett davidmpickett enabled auto-merge (squash) September 6, 2024 20:13
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 9, 2024 15:25 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 9, 2024 15:38 Destroyed
@davidmpickett davidmpickett merged commit 8e42f34 into main Sep 9, 2024
18 checks passed
@davidmpickett davidmpickett deleted the VACMS-17477-news-release-character-counter branch September 9, 2024 16:29
timcosgrove pushed a commit that referenced this pull request Sep 12, 2024
* Updated character count to match guidance

* Undeleted help text
keisterj-oddball pushed a commit that referenced this pull request Sep 19, 2024
* Updated character count to match guidance

* Undeleted help text
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Facilities Facilities products (VAMC, Vet Center, etc) News release CMS managed product owned by Facilities team sitewide
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants