-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VACMS-17477: Updated character counter on News Releases #19126
Merged
davidmpickett
merged 4 commits into
main
from
VACMS-17477-news-release-character-counter
Sep 9, 2024
Merged
VACMS-17477: Updated character counter on News Releases #19126
davidmpickett
merged 4 commits into
main
from
VACMS-17477-news-release-character-counter
Sep 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmpickett
changed the title
VACMS-17477: Updated character counter on New Releases
VACMS-17477: Updated character counter on News Releases
Sep 5, 2024
davidmpickett
added
sitewide
Facilities
Facilities products (VAMC, Vet Center, etc)
News release
CMS managed product owned by Facilities team
labels
Sep 5, 2024
jv-agile6
approved these changes
Sep 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed
- core.entity_form_display.node.press_release.default.yml
- field.field.node.press_release.field_intro_text.yml
- node.type.press_release.yml
Followed addition and subtraction to yml files. No defects noted.
laflannery
approved these changes
Sep 6, 2024
thejordanwood
approved these changes
Sep 6, 2024
davidmpickett
force-pushed
the
VACMS-17477-news-release-character-counter
branch
from
September 6, 2024 19:49
07351be
to
05df62b
Compare
timcosgrove
pushed a commit
that referenced
this pull request
Sep 12, 2024
* Updated character count to match guidance * Undeleted help text
keisterj-oddball
pushed a commit
that referenced
this pull request
Sep 19, 2024
* Updated character count to match guidance * Undeleted help text
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Facilities
Facilities products (VAMC, Vet Center, etc)
News release
CMS managed product owned by Facilities team
sitewide
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Relates to #17477
Testing done
Manual testing of the News Release content type on Tugboat
Screenshots
QA steps
What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?
Definition of Done