Merge branch 'master' into 94285-refactor-log-email-diff-job

.github/CODEOWNERS

@@ -165,7 +165,6 @@ app/controllers/v1/decision_review_evidences_controller.rb @department-of-vetera
 app/controllers/v1/decision_review_notification_callbacks_controller.rb @department-of-veterans-affairs/benefits-decision-reviews-be @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 app/controllers/v1/apidocs_controller.rb @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 app/controllers/v1/notice_of_disagreements_controller.rb @department-of-veterans-affairs/benefits-decision-reviews-be @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
-app/controllers/v1/pension_ipf_callbacks_controller.rb @department-of-veterans-affairs/pension-and-burials @department-of-veterans-affairs/backend-review-group
 app/controllers/v1/sessions_controller.rb  @department-of-veterans-affairs/octo-identity
 app/controllers/v1/supplemental_claims_controller.rb @department-of-veterans-affairs/benefits-decision-reviews-be @department-of-veterans-affairs/backend-review-group
 app/controllers/v1/supplemental_claims @department-of-veterans-affairs/benefits-decision-reviews-be @department-of-veterans-affairs/backend-review-group

.github/workflows/be_review_prs.yml

@@ -1,7 +1,5 @@
 name: Require backend-review-group approval
 on:
-  pull_request:
-    types: [opened, reopened, review_requested, synchronize, ready_for_review]
   pull_request_review:
     types: [submitted]
 

Gemfile

@@ -64,7 +64,7 @@ gem 'connect_vbms', git: 'https://github.com/adhocteam/connect_vbms', tag: 'v2.1
 gem 'csv'
 gem 'date_validator'
 gem 'ddtrace'
-gem 'dogstatsd-ruby', '5.6.2'
+gem 'dogstatsd-ruby', '5.6.3'
 gem 'dry-struct'
 gem 'dry-types'
 gem 'ethon', '>=0.13.0'

Gemfile.lock

@@ -376,7 +376,7 @@ GEM
       thread_safe (~> 0.3, >= 0.3.1)
     diff-lcs (1.5.1)
     docile (1.4.0)
-    dogstatsd-ruby (5.6.2)
+    dogstatsd-ruby (5.6.3)
     domain_name (0.6.20240107)
     down (5.4.2)
       addressable (~> 2.8)
@@ -1162,7 +1162,7 @@ DEPENDENCIES
   ddtrace
   debts_api!
   dhp_connected_devices!
-  dogstatsd-ruby (= 5.6.2)
+  dogstatsd-ruby (= 5.6.3)
   dry-struct
   dry-types
   ethon (>= 0.13.0)

app/controllers/v0/health_care_applications_controller.rb

@@ -19,6 +19,12 @@ class HealthCareApplicationsController < ApplicationController
     before_action(only: :rating_info) { authorize(:hca_disability_rating, :access?) }
 
     def rating_info
+      if Flipper.enabled?(:hca_disable_bgs_service)
+        # Return 0 when not calling the actual BGS::Service
+        render json: HCARatingInfoSerializer.new({ user_percent_of_disability: 0 })
+        return
+      end
+
       service = BGS::Service.new(current_user)
       disability_rating = service.find_rating_data[:disability_rating_record][:service_connected_combined_degree]
 

app/services/medical_copays/request.rb

@@ -44,13 +44,32 @@ def initialize
     # @return [Faraday::Response]
     #
     def post(path, params)
-      with_monitoring do
-        connection.post(path) do |req|
-          req.body = Oj.dump(params)
+      if Flipper.enabled?(:debts_copay_logging) && !Rails.env.development?
+        with_monitoring_and_error_handling do
+          connection.post(path) do |req|
+            req.body = Oj.dump(params)
+          end
+        end
+      else
+        with_monitoring do
+          connection.post(path) do |req|
+            req.body = Oj.dump(params)
+          end
         end
       end
     end
 
+    def with_monitoring_and_error_handling(&)
+      with_monitoring(2, &)
+    rescue => e
+      handle_error(e)
+    end
+
+    def handle_error(error)
+      Rails.logger.error("MedicalCopays::Request error: #{error.message}")
+      raise error
+    end
+
     ##
     # Make a HTTP GET call to the VBS service in order to obtain copays or PDFs by id
     #

app/services/medical_copays/vbs/service.rb

@@ -117,6 +117,10 @@ def get_pdf_statement_by_id(statement_id)
       end
 
       def get_copay_response
+        if Flipper.enabled?(:debts_copay_logging)
+          Rails.logger.info("MedicalCopays::VBS::Service#get_copay_response request data: #{@user.uuid}")
+        end
+
         request.post("#{settings.base_path}/GetStatementsByEDIPIAndVistaAccountNumber", request_data.to_hash)
       end
 

app/sidekiq/benefits_intake_status_job.rb

@@ -197,7 +197,7 @@ def monitor_failure(form_id, saved_claim_id, bi_uuid)
     if %w[28-1900].include?(form_id)
       claim = SavedClaim::VeteranReadinessEmploymentClaim.find(saved_claim_id)
       if claim
-        claim.submit_failure_email
+        claim.send_failure_email
         VRE::Monitor.new.log_silent_failure_avoided(context, nil, call_location:)
       else
         VRE::Monitor.new.log_silent_failure(context, nil, call_location:)

config/features.yml

@@ -79,6 +79,9 @@ features:
   hca_browser_monitoring_enabled:
     actor_type: user
     description: Enables browser monitoring for the health care application.
+  hca_disable_bgs_service:
+    actor_type: user
+    description: Do not call the BGS Service when this is turned on. Instead return 0 for rating.
   hca_enrollment_status_override_enabled:
     actor_type: user
     description: Enables override of enrollment status for a user, to allow multiple submissions with same user.
@@ -372,6 +375,9 @@ features:
   debts_cache_vbs_copays_empty_response:
     actor_type: user
     description: Enables caching of empty VBS medical copay response
+  debts_copay_logging:
+    actor_type: user
+    description: Logs copay request data
   decision_review_hlr_email:
     actor_type: user
     description: Send email notification for successful HLR submission
@@ -1151,6 +1157,9 @@ features:
   my_va_form_submission_statuses:
     actor_type: user
     description: Enables users to view the status of submitted forms.
+  my_va_form_submission_pdf_link:
+    actor_type: user
+    description: Enables users to view PDF link within submitted forms cards
   rated_disabilities_detect_discrepancies:
     actor_type: user
     description:
@@ -1690,10 +1699,6 @@ features:
     actor_type: user
     description: Supplemental Claim new form updates
     enable_in_development: true
-  pension_ipf_callbacks_endpoint:
-    actor_type: user
-    description: Pension IPF VANotify notification callbacks endpoint
-    enable_in_development: true
   hlr_browser_monitoring_enabled:
     actor_type: user
     description: HLR Datadog RUM monitoring

config/routes.rb

@@ -441,7 +441,6 @@
 
     scope format: false do
       resources :nod_callbacks, only: [:create], controller: :decision_review_notification_callbacks
-      resources :pension_ipf_callbacks, only: [:create]
     end
   end
 

config/settings.yml

@@ -1792,9 +1792,6 @@ brd:
 nod_vanotify_status_callback:
   bearer_token: bearer_token_secret
 
-pension_ipf_vanotify_status_callback:
-  bearer_token: bearer_token_secret
-
 travel_pay:
   sts:
     service_account_id: ~

config/settings/test.yml

@@ -449,9 +449,6 @@ travel_pay:
   client_number: '12345'
   service_name: 'BTSSS-API'
 
-pension_ipf_vanotify_status_callback:
-  bearer_token: bearer_token_secret
-
 va_notify:
   status_callback:
     bearer_token: 'va_notify_bearer_token'

db/migrate/20241112172605_add_index_to_form_email_matches_profile_logs.rb

@@ -2,6 +2,10 @@ class AddIndexToFormEmailMatchesProfileLogs < ActiveRecord::Migration[7.1]
   disable_ddl_transaction!
 
   def change
-    add_index :form_email_matches_profile_logs, [:user_uuid, :in_progress_form_id], unique: true, algorithm: :concurrently
+    add_index :form_email_matches_profile_logs,
+              %i[user_uuid in_progress_form_id],
+              unique: true,
+              algorithm: :concurrently,
+              if_not_exists: true
   end
 end

modules/claims_api/app/models/claims_api/auto_established_claim.rb

@@ -82,6 +82,7 @@ def to_internal # rubocop:disable Metrics/MethodLength
       resolve_homelessness_risk_situation_type_mappings!
       transform_homelessness_point_of_contact_primary_phone!
       transform_address_lines_length!
+      transform_empty_unit_name!
 
       {
         form526: form_data
@@ -533,5 +534,14 @@ def transform_address_lines_length!
 
       form_data['veteran']['currentMailingAddress'] = addr
     end
+
+    def transform_empty_unit_name!
+      reserves = form_data&.dig('serviceInformation', 'reservesNationalGuardService')
+      return if reserves.nil?
+
+      unit_name = reserves['unitName']
+      unit_name = unit_name.presence || ' '
+      reserves['unitName'] = unit_name
+    end
   end
 end

modules/claims_api/spec/models/auto_establish_claim_spec.rb

@@ -553,6 +553,21 @@
     end
   end
 
+  describe '#transform_empty_unit_name!' do
+    let(:unit_name) { '' }
+
+    it 'trasforms an empty unit name to a space' do
+      temp_form_data = pending_record.form_data
+      temp_form_data['serviceInformation']['reservesNationalGuardService']['unitName'] = unit_name
+
+      pending_record.form_data = temp_form_data
+      payload = JSON.parse(pending_record.to_internal)
+      name = payload['form526']['serviceInformation']['reservesNationalGuardService']['unitName']
+
+      expect(name).to eq(' ')
+    end
+  end
+
   describe 'evss_id_by_token' do
     context 'with a record' do
       let(:evss_record) { create(:auto_established_claim, evss_id: 123_456) }