API-41897-remove-updatepoaaccess-for-dependent-claimant

[rockwellwindsor-va]

Summary

• Updates poa updater to skip running poa vbms updater job if we are in the dependent workflow
• Adds/updates related tests

graph TD;
    A{submission} -->B[PoaFormBuilderJob];
    B --> C(Is it a dependent filing?);
    C --> D{Yes};
    C --> E{No};
    D --> F[PoaAssignDependentClaimantJob];
    E --> H[POAUpdaterJob];
    H --> G[PoaVBMSUpdater];

Loading

Related issue(s)

API-41897

Testing done

• New code is covered by unit tests

Testing notes

• Submitting a request for a dependent claimant should skip the poa vbms updater sidekiq job since we do not want to call updatePoaAccess n that workflow

Screenshots

Note: Optional

What areas of the site does it impact?

modified:   modules/claims_api/app/sidekiq/claims_api/poa_updater.rb
modified:   modules/claims_api/spec/sidekiq/poa_updater_spec.rb

Acceptance criteria

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No error nor warning in the console.
• Events are being sent to the appropriate logging solution
• Documentation has been updated (link to documentation)
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Feature/bug has a monitor built into Datadog (if applicable)
• If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
• I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

[tycol7]

Iʼm not sure the extra helper methods add any value. Could we instead just say:

Suggested change

	if enable_vbms_access?(poa_form:) && update_poa_access?(poa_form.auth_headers)
	if enable_vbms_access?(poa_form:) && poa_form.auth_headers['dependent'].blank?

?

[rockwellwindsor-va]

@tycol7 Yep makes sense, b26e5c3