Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename argument in get_supplemental_claim_upload #19480

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kayline
Copy link
Contributor

@kayline kayline commented Nov 15, 2024

Summary

  • This work is behind a feature toggle (flipper): NO
  • was :uuid, now :guid
  • to match get_notice_of_disagreement_upload for easier code sharing and shared testing
  • Decision Reviews, yes

Related issue(s)

department-of-veterans-affairs/va.gov-team#96645

Testing done

  • New code is covered by unit tests
  • Changed one named argument from :uuid to :guid

What areas of the site does it impact?

DecisionReviewV1::Appeals::SupplementalClaimServices

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@va-vfs-bot va-vfs-bot temporarily deployed to DR-refactor-status-check-service/main/main November 15, 2024 18:21 Inactive
- was :uuid, now :guid
- to match get_notice_of_disagreement_upload for easier code sharing and shared testing
Copy link
Contributor

@shaunburdick shaunburdick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants